unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: raman@comcast.net (raman)
To: raman@users.sf.net
Cc: emacs-devel@gnu.org
Subject: Re: ad-interactive-form vs interactive-form
Date: Fri, 27 Jul 2007 07:34:22 -0700 (PDT)	[thread overview]
Message-ID: <20070727143422.41D2312A4145@localhost> (raw)
In-Reply-To: <18089.63150.623907.647640@gargle.gargle.HOWL>

Hi Stefan,

This is a follow-up to the message I sent
 earlier this morning.

I spotted the cause of the problem  that I was hitting when using
interactive-form instead of ad-interactive-form:

interactive-form returns the autoload list for autoloaded functions,
ad-interactive-form used to return nil.

I therefore needed to add a check for (functionp (symbol-function sym))
before allowing Emacspeak to go off and auto-hack interactive functions.

Incidentaly, that corner of Emacspeak is a particularly hairy piece of
code that does:

0) Find functions that use an interactive spec for  declaring their
prompts.  1)    For those decls that dont use the minibuffer, perform
surgery to make those functions use the minibuffer.

The above was needed for a large number of functions until Emacs 21
--- since most  prompting resulting from interactive decls happened
directly through the C code in callint.c -- and consequently, Emacspeak
making functions like read-from-minibuffer or read-file-name was not
sufficient --- I needed to do the work  to perform run-time surgery to
functions that used interactive. As of emacs 21, I only need to do this
to commands that  use either 'c' or 'k' in their interactive spec --
would be nice to make those prompts go through the lisp layer as well --
in which case I could get rid of emacspeak-fix-interactive entirely.

       reply	other threads:[~2007-07-27 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <18089.63150.623907.647640@gargle.gargle.HOWL>
2007-07-27 14:34 ` raman [this message]
2007-07-27 19:11   ` ad-interactive-form vs interactive-form Stefan Monnier
2007-07-29  2:22     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070727143422.41D2312A4145@localhost \
    --to=raman@comcast.net \
    --cc=emacs-devel@gnu.org \
    --cc=raman@users.sf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).