From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: undo info for `*cvs-diff*' Date: Wed, 25 Jul 2007 09:53:29 -0700 Message-ID: <200707251653.l6PGrTJ5011302@oogie-boogie.ics.uci.edu> References: <200707232122.l6NLM1BP015977@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185382450 3449 80.91.229.12 (25 Jul 2007 16:54:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Jul 2007 16:54:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 25 18:54:08 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDk7k-00061q-CT for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 18:54:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDk7j-0000r0-UK for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 12:54:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDk7h-0000qt-1A for emacs-devel@gnu.org; Wed, 25 Jul 2007 12:54:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDk7e-0000qf-Qh for emacs-devel@gnu.org; Wed, 25 Jul 2007 12:54:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDk7e-0000qc-NN for emacs-devel@gnu.org; Wed, 25 Jul 2007 12:54:02 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IDk7e-0000L8-4M for emacs-devel@gnu.org; Wed, 25 Jul 2007 12:54:02 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l6PGrTJ5011302; Wed, 25 Jul 2007 09:53:29 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed\, 25 Jul 2007 00\:48\:50 -0400") Original-Lines: 45 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.763, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_42 0.60, TW_LB 0.08) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75527 Archived-At: Stefan Monnier writes: > > ,----[ *Warnings* ] > > | Warning (undo): Buffer `*cvs-diff*' undo info was 5641808 bytes long. > > | The undo info was discarded because it exceeded `undo-outer-limit'. > > | [...] > > `---- > > I believe I know what was causing this trouble. Can you try the > patch below which I just installed in the 22 branch? > > > Stefan > > > --- pcvs.el 25 jui 2007 00:41:22 -0400 1.98.2.4 > +++ pcvs.el 25 jui 2007 00:43:49 -0400 > @@ -392,17 +392,18 @@ > (with-current-buffer buf > (setq buffer-read-only nil) > (setq default-directory dir) > - (unless nosetup (erase-buffer)) > + (unless nosetup > + (buffer-disable-undo) > + (erase-buffer)) > (set (make-local-variable 'cvs-buffer) cvs-buf) > ;;(cvs-minor-mode 1) > (let ((lbd list-buffers-directory)) > - (if (fboundp mode) (funcall mode) > - (fundamental-mode) > - (buffer-disable-undo)) > + (if (fboundp mode) (funcall mode) (fundamental-mode)) > (when lbd (set (make-local-variable 'list-buffers-directory) lbd))) > (cvs-minor-mode 1) > ;;(set (make-local-variable 'cvs-buffer) cvs-buf) > - (unless normal > + (if normal > + (buffer-enable-undo) > (setq buffer-read-only t) > (buffer-disable-undo)) > buf))) Applying it to HEAD makes the problem disappear for me. Thanks!