From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: vc-find-root does not work for non-existent file argument Date: Sat, 21 Jul 2007 09:59:49 -0700 Message-ID: <200707211659.l6LGxo7m017360@oogie-boogie.ics.uci.edu> References: <200707160050.l6G0oxfm014234@oogie-boogie.ics.uci.edu> <200707201756.l6KHu2MO020412@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185037369 1084 80.91.229.12 (21 Jul 2007 17:02:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 Jul 2007 17:02:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 21 19:02:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ICILt-0006Do-Kn for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2007 19:02:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICILt-0001K6-Aa for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2007 13:02:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ICILp-0001IH-PN for emacs-devel@gnu.org; Sat, 21 Jul 2007 13:02:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ICILn-0001Hr-GM for emacs-devel@gnu.org; Sat, 21 Jul 2007 13:02:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICILn-0001Ho-Cv for emacs-devel@gnu.org; Sat, 21 Jul 2007 13:02:39 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ICILm-0001w4-PK for emacs-devel@gnu.org; Sat, 21 Jul 2007 13:02:39 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l6LGxo7m017360; Sat, 21 Jul 2007 09:59:50 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri\, 20 Jul 2007 14\:09\:44 -0400") Original-Lines: 24 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75244 Archived-At: Stefan Monnier writes: > >> > If FILE that is managed using either hg or bzr (both of which use > >> > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not > >> > result emacs asking the question: "File FILE was lost; check out from > >> > version control? " > >> > >> > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks > >> > that FILE is not under version control. > >> > vc-find-root returns nil because of the way the result of > >> > file-attributes is used... > >> > >> I believe this is fixed now, but there seem to be a related problem left > >> over, ... working on it, > > > Is the issue you are still looking at something like this: > > > mkdir -p /tmp/foo/bar > > > (vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? > > Yes, and I believe it is fixed now, Can you please fix it on the 22.2 branch too?