unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: emacs-devel@gnu.org
Subject: avoiding revert-buffer after vc-checkin
Date: Tue, 17 Jul 2007 22:47:56 -0700	[thread overview]
Message-ID: <200707180547.l6I5luxe002955@oogie-boogie.ics.uci.edu> (raw)


After a vc-checkin the corresponding buffer is reverted, which is not
so convenient because the undo information is lost. 

One way to avoid the revert is to check if the buffer and the file on
disk are identical. One way to do that is to compare the md5
checksums.

I wrote a patch that does that almost a year ago, I never fully
verified it if it works correctly, and I don't think I'll touch it
again anytime soon. So I thought I'd throw it over the fence and maybe
it will inspire someone to pick it up and solve this problem
properly. Pretty please :-)

Index: vc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
retrieving revision 1.433
diff -c -3 -p -c -r1.433 vc.el
*** vc.el       17 Jul 2007 04:47:57 -0000      1.433
--- vc.el       18 Jul 2007 05:10:40 -0000
*** 1530,1536 ****
    (and (string= buffer-file-name file)
         (if keep
           (progn
!            (vc-revert-buffer1 t noquery)
               ;; TODO: Adjusting view mode might no longer be necessary
               ;; after RMS change to files.el of 1999-08-08.  Investigate
               ;; this when we install the new VC.
--- 1530,1542 ----
    (and (string= buffer-file-name file)
         (if keep
           (progn
!            (if (string=
!                 (substring (shell-command-to-string 
!                             (concat "md5sum " (expand-file-namefile))) 0 32)
!                 (md5 (current-buffer)))
!                (message "not reverting")
!              (message "reverting :-(")
!              (vc-revert-buffer1 t noquery))
               ;; TODO: Adjusting view mode might no longer be necessary
               ;; after RMS change to files.el of 1999-08-08.  Investigate
               ;; this when we install the new VC.


The reason the md5sum command is used is because `md5' cannot take a
file argument.

             reply	other threads:[~2007-07-18  5:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  5:47 Dan Nicolaescu [this message]
2007-07-18 18:53 ` avoiding revert-buffer after vc-checkin Stefan Monnier
2007-07-18 21:21   ` David Kastrup
2007-07-19  2:57     ` Stefan Monnier
2007-07-19 21:21   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707180547.l6I5luxe002955@oogie-boogie.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).