From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Help hyperlinks only work when auto-compression-mode is enabled. Date: Mon, 11 Jun 2007 00:49:11 +0100 Message-ID: <20070610234911.GB1867@muc.de> References: <20070610101159.GA2311@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181514233 389 80.91.229.12 (10 Jun 2007 22:23:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2007 22:23:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 11 00:23:51 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HxVp9-0004eN-2X for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 00:23:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxVp8-0004zT-1L for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2007 18:23:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxVp4-0004zN-Kv for emacs-devel@gnu.org; Sun, 10 Jun 2007 18:23:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxVp3-0004zB-Cs for emacs-devel@gnu.org; Sun, 10 Jun 2007 18:23:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxVp3-0004z8-8O for emacs-devel@gnu.org; Sun, 10 Jun 2007 18:23:45 -0400 Original-Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HxVp2-0005f8-Pd for emacs-devel@gnu.org; Sun, 10 Jun 2007 18:23:45 -0400 Original-Received: (qmail 97890 invoked by uid 3782); 10 Jun 2007 22:23:43 -0000 Original-Received: from acm.muc.de (p54A3D239.dip.t-dialin.net [84.163.210.57]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Mon, 11 Jun 2007 00:23:40 +0200 Original-Received: (qmail 4435 invoked by uid 1000); 10 Jun 2007 23:49:11 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-kernel: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72593 Archived-At: Hi, Richard. On Sun, Jun 10, 2007 at 05:00:35PM -0400, Richard Stallman wrote: > 2007-06-10 Alan Mackenzie > > * help-mode.el (help-function-def, help-variable-def, > help-face-def): Use `with-auto-compression-mode'. > > The right way to format that, according to our conventions, is > 2007-06-10 Alan Mackenzie > > * help-mode.el (help-function-def, help-variable-def) > (help-face-def): Use `with-auto-compression-mode'. Sorry about that. > The code looks correct. But would it be better to do this in the > subroutines in find-func.el? I don't think so. Anybody who's knowingly disabled auto-compression-mode will have a good reason for doing so, and will surely know what she's doing. She won't want the find-func functions to find foo.el.gz. Maybe there's a stable foo.el.gz higher on the search path, and there's an foo.el being actively developed. Maybe some source files are being compressed to hide them. However, this user didn't ask for the Emacs-22 sources to be compressed, any more than I did. It just happened with the "make install". So we're entitled to see these sources on clicking the hyperlink in C-h f. If we were to put the fix in `find-function-search-for-symbol' (or even lower), this would identify these two cases which should remain distinct. So I think the fix should be in help-mode.el. -- Alan.