unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Help hyperlinks only work when auto-compression-mode is enabled.
Date: Mon, 11 Jun 2007 00:49:11 +0100	[thread overview]
Message-ID: <20070610234911.GB1867@muc.de> (raw)
In-Reply-To: <E1HxUWZ-00008V-3A@fencepost.gnu.org>

Hi, Richard.

On Sun, Jun 10, 2007 at 05:00:35PM -0400, Richard Stallman wrote:
>     2007-06-10  Alan Mackenzie  <acm@muc.de>
> 
> 	    * help-mode.el (help-function-def, help-variable-def,
> 	    help-face-def): Use `with-auto-compression-mode'.
> 
> The right way to format that, according to our conventions, is

>     2007-06-10  Alan Mackenzie  <acm@muc.de>
> 
> 	    * help-mode.el (help-function-def, help-variable-def)
> 	    (help-face-def): Use `with-auto-compression-mode'.

Sorry about that.
 
> The code looks correct.  But would it be better to do this in the
> subroutines in find-func.el?
 
I don't think so.  Anybody who's knowingly disabled auto-compression-mode
will have a good reason for doing so, and will surely know what she's
doing.  She won't want the find-func functions to find foo.el.gz.  Maybe
there's a stable foo.el.gz higher on the search path, and there's an
foo.el being actively developed.  Maybe some source files are being
compressed to hide them.

However, this user didn't ask for the Emacs-22 sources to be compressed,
any more than I did.  It just happened with the "make install".  So we're
entitled to see these sources on clicking the hyperlink in C-h f.

If we were to put the fix in `find-function-search-for-symbol' (or even
lower), this would identify these two cases which should remain distinct.

So I think the fix should be in help-mode.el.

-- 
Alan.

  reply	other threads:[~2007-06-10 23:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-10 10:11 Help hyperlinks only work when auto-compression-mode is enabled Alan Mackenzie
2007-06-10 19:26 ` Stefan Monnier
2007-06-10 21:04   ` Alan Mackenzie
2007-06-11  1:11     ` Stefan Monnier
2007-06-10 21:00 ` Richard Stallman
2007-06-10 23:49   ` Alan Mackenzie [this message]
2007-06-12 16:00     ` Richard Stallman
2007-06-15 22:35       ` Alan Mackenzie
2007-06-16 18:50         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070610234911.GB1867@muc.de \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).