From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: Emacs unicode 2 build failed Date: Mon, 28 May 2007 20:03:13 +0300 Message-ID: <20070528170313.GA69126@kobe.laptop> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1180371974 829 80.91.229.12 (28 May 2007 17:06:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 May 2007 17:06:14 +0000 (UTC) Cc: Herbert Euler , emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 28 19:06:12 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hsifb-00056r-Lu for ged-emacs-devel@m.gmane.org; Mon, 28 May 2007 19:06:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hsifb-0002GL-Cw for ged-emacs-devel@m.gmane.org; Mon, 28 May 2007 13:06:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HsifZ-0002GG-0X for emacs-devel@gnu.org; Mon, 28 May 2007 13:06:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HsifX-0002Fd-Et for emacs-devel@gnu.org; Mon, 28 May 2007 13:06:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HsifX-0002FV-3T for emacs-devel@gnu.org; Mon, 28 May 2007 13:06:07 -0400 Original-Received: from igloo.linux.gr ([62.1.205.36]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HsifW-00075V-Aq for emacs-devel@gnu.org; Mon, 28 May 2007 13:06:06 -0400 Original-Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-3) with ESMTP id l4SH3V8k020000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 28 May 2007 20:03:42 +0300 Original-Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.1/8.14.1) with ESMTP id l4SH3DXY094940; Mon, 28 May 2007 20:03:25 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from keramida@localhost) by kobe.laptop (8.14.1/8.14.1/Submit) id l4SH3DMH094910; Mon, 28 May 2007 20:03:13 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.527, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.67, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-detected-kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71895 Archived-At: On 2007-05-28 15:55, Kenichi Handa wrote: > In article , "Herbert Euler" writes: > > > The error message is > > gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -I. > > -I/home/xgp/src/emacs/newcvs/emacs/src -D_BSD_SOURCE -g -O2 term.c > > In file included from term.c:418: > > buffer.h:403: redefinition of `struct buffer_text' > > buffer.h:461: redefinition of `struct buffer' > > make[1]: *** [term.o] Error 1 > > make[1]: Leaving directory `/home/xgp/src/emacs/newcvs/emacs/src' > > make: *** [src] Error 2 > > > term.c includes buffer.h twice and there is no any protection in > > buffer.h > > I've just deleted the second include. Wouldn't it be a `better' solution to add something like the following to buffer.h, to avoid multiple inclusions of the header text? %%% diff -Nprc3 gnu.c9d9b15c47d7/src/buffer.h gnu/src/buffer.h *** gnu.c9d9b15c47d7/src/buffer.h Mon May 28 20:02:15 2007 --- gnu/src/buffer.h Mon May 28 20:02:15 2007 *************** along with GNU Emacs; see the file COPYI *** 19,24 **** --- 19,26 ---- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ + #ifndef EMACS_BUFFER_H + #define EMACS_BUFFER_H /* Accessing the parameters of the current buffer. */ *************** extern int last_per_buffer_idx; *** 1003,1005 **** --- 1005,1009 ---- /* arch-tag: 679305dd-d41c-4a50-b170-3caf5c97b2d1 (do not change this comment) */ + + #endif /* EMACS_BUFFER_H */ %%%