From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: CVS HEAD fails to build Date: Mon, 7 May 2007 23:51:41 +0300 Message-ID: <20070507205140.GA95537@kobe.laptop> References: <86sla8cwjm.fsf@blue.stonehenge.com> <20070507185701.GB7062@kobe.laptop> <20070507195033.GA65730@kobe.laptop> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1178571178 27001 80.91.229.12 (7 May 2007 20:52:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 May 2007 20:52:58 +0000 (UTC) Cc: emacs-devel@gnu.org, "Randal L. Schwartz" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 07 22:52:56 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HlACS-0004kK-KL for ged-emacs-devel@m.gmane.org; Mon, 07 May 2007 22:52:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HlAJS-0002hl-UU for ged-emacs-devel@m.gmane.org; Mon, 07 May 2007 17:00:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HlAJP-0002h7-JN for emacs-devel@gnu.org; Mon, 07 May 2007 17:00:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HlAJO-0002gR-0g for emacs-devel@gnu.org; Mon, 07 May 2007 17:00:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HlAJN-0002gN-RP for emacs-devel@gnu.org; Mon, 07 May 2007 17:00:01 -0400 Original-Received: from igloo.linux.gr ([62.1.205.36]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HlACM-00080c-0v for emacs-devel@gnu.org; Mon, 07 May 2007 16:52:46 -0400 Original-Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-3) with ESMTP id l47Kq2h1026541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 7 May 2007 23:52:09 +0300 Original-Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.1/8.14.1) with ESMTP id l47KphCL097290; Mon, 7 May 2007 23:51:55 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from keramida@localhost) by kobe.laptop (8.14.1/8.14.1/Submit) id l47KpfVF097289; Mon, 7 May 2007 23:51:41 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Content-Disposition: inline In-Reply-To: <20070507195033.GA65730@kobe.laptop> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.524, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.68, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-detected-kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70634 Archived-At: On 2007-05-07 22:50, Giorgos Keramidas wrote: > The first bad revision is: > changeset: 81110:6207e966040e > user: monnier > date: Mon May 07 15:41:37 2007 +0000 > summary: (Fdefine_key, Flookup_key): Only do the 0x80->meta_modifier Hi Stefan and all, this part of the change seems to be the one which is causing the build problem: % diff -r 62063c2fb043 -r 6207e966040e src/keymap.c % --- a/src/keymap.c Mon May 07 08:05:55 2007 +0000 % +++ b/src/keymap.c Mon May 07 15:41:37 2007 +0000 % @@ -1312,7 +1313,7 @@ recognize the default bindings, just as % c = Fevent_convert_list (c); % % /* Turn the 8th bit of string chars into a meta modifier. */ % - if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key)) % + if (STRINGP (key) && XINT (c) & 0x8 && !STRING_MULTIBYTE (key)) % XSETINT (c, (XINT (c) | meta_modifier) & ~0x80); % % /* Allow string since binding for `menu-bar-select-buffer' I have locally reverted the condition to: if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key) && !STRING_MULTIBYTE (key)) XSETINT (c, (XINT (c) | meta_modifier) & ~0x80); but I am not sure if it matches what you originally intended to do, Stefan. Does the new check seem reasonable? - Giorgos