Re: CVS HEAD fails to build

[Giorgos Keramidas <keramida@ceid.upatras.gr>]

On 2007-05-07 22:50, Giorgos Keramidas <keramida@ceid.upatras.gr> wrote:
> The first bad revision is:
> changeset:   81110:6207e966040e
> user:        monnier
> date:        Mon May 07 15:41:37 2007 +0000
> summary:     (Fdefine_key, Flookup_key): Only do the 0x80->meta_modifier

Hi Stefan and all,

this part of the change seems to be the one which is causing the
build problem:

% diff -r 62063c2fb043 -r 6207e966040e src/keymap.c
% --- a/src/keymap.c      Mon May 07 08:05:55 2007 +0000
% +++ b/src/keymap.c      Mon May 07 15:41:37 2007 +0000
% @@ -1312,7 +1313,7 @@ recognize the default bindings, just as
%         c = Fevent_convert_list (c);
%
%        /* Turn the 8th bit of string chars into a meta modifier.  */
% -      if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key))
% +      if (STRINGP (key) && XINT (c) & 0x8 && !STRING_MULTIBYTE (key))
%          XSETINT (c, (XINT (c) | meta_modifier) & ~0x80);
%
%        /* Allow string since binding for `menu-bar-select-buffer'

I have locally reverted the condition to:

         if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key) &&
             !STRING_MULTIBYTE (key))
           XSETINT (c, (XINT (c) | meta_modifier) & ~0x80);

but I am not sure if it matches what you originally intended to do,
Stefan.  Does the new check seem reasonable?

- Giorgos