Small `c-electric-paren' fix

Small `c-electric-paren' fix

[David Hansen]

Hello,

I've already send this to the cc-mode list some time ago (X-Post
anyway) but seems the maintainer is kinda busy.  Can someone else
please take care of it?  It's clearly a bug and the fix is pretty
short and obvious.

To reproduce:

(defun dh-c-mode-hook ()
  (push 'space-before-funcall c-cleanup-list))

(add-hook 'c-mode-hook #'dh-c-mode-hook)


Now open some .c file and type some parenthesis.  A space is
automatically inserted even if the paren is not a function call.

Fix:

Index: lisp/progmodes/cc-cmds.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/cc-cmds.el,v
retrieving revision 1.55
diff -u -r1.55 cc-cmds.el
--- lisp/progmodes/cc-cmds.el	30 Mar 2007 20:20:35 -0000	1.55
+++ lisp/progmodes/cc-cmds.el	31 Mar 2007 09:27:03 -0000
@@ -1262,11 +1262,11 @@
 		     (backward-char)
 		     (skip-chars-backward " \t")
 		     (setq beg (point))
-		     (c-save-buffer-state () (c-on-identifier))
-		     ;; Don't add a space into #define FOO()....
-		     (not (and (c-beginning-of-macro)
-			       (c-forward-over-cpp-define-id)
-			       (eq (point) beg)))))
+		     (and (c-save-buffer-state () (c-on-identifier))
+                          ;; Don't add a space into #define FOO()....
+                          (not (and (c-beginning-of-macro)
+                                    (c-forward-over-cpp-define-id)
+                                    (eq (point) beg))))))
 	      (save-excursion
 		(delete-region beg end)
 		(goto-char beg)

Re: Small `c-electric-paren' fix

[Alan Mackenzie]

Hi, David!

On Sat, Mar 31, 2007 at 02:15:46PM +0200, David Hansen wrote:
> Hello,

> I've already send this to the cc-mode list some time ago (X-Post
> anyway) but seems the maintainer is kinda busy.  Can someone else
> please take care of it?  It's clearly a bug and the fix is pretty
> short and obvious.

Sorry, I missed your post to bug-cc-mode.  At the moment I can't post to
the CC Mode list at sourceforge, at least not without hassle, because
they've got a buggy Spamassassin setting which mis-characterizes the Date
header generated by Mutt as invalid.  They've been promising to fix it
since at least January.  There seem to be major mailing list problems
there too at the moment.

> To reproduce:

> (defun dh-c-mode-hook ()
>   (push 'space-before-funcall c-cleanup-list))

> (add-hook 'c-mode-hook #'dh-c-mode-hook)


> Now open some .c file and type some parenthesis.  A space is
> automatically inserted even if the paren is not a function call.

Whoops!  That's bad.  I'll fix it this week.  Thanks for the bug report.

-- 
Alan Mackenzie (Ittersbach, Germany)

Re: Small `c-electric-paren' fix

[Alan Mackenzie]

Hi, David!

On Sat, Mar 31, 2007 at 02:15:46PM +0200, David Hansen wrote:
> Hello,
 
> I've already send this to the cc-mode list some time ago (X-Post
> anyway) but seems the maintainer is kinda busy.  Can someone else
> please take care of it?  It's clearly a bug and the fix is pretty
> short and obvious.
 
DONE.
 
> To reproduce:
> 
> (defun dh-c-mode-hook ()
>   (push 'space-before-funcall c-cleanup-list))
> 
> (add-hook 'c-mode-hook #'dh-c-mode-hook)
> 
> 
> Now open some .c file and type some parenthesis.  A space is
> automatically inserted even if the paren is not a function call.

-- 
Alan Mackenzie (Ittersbach, Germany)