From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] autorevert.el -- revert fix for Windows platform Date: Fri, 23 Mar 2007 13:48:01 -0500 (CDT) Message-ID: <200703231848.l2NIm1Je019277@jane.dms.auburn.edu> References: <7it9frhi.fsf@cante.net> <87slbx9vcf.fsf@stupidchicken.com> <46040576.9090505@gnu.org> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1174675843 1691 80.91.229.12 (23 Mar 2007 18:50:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 18:50:43 +0000 (UTC) Cc: eliz@gnu.org, jari.aalto@cante.net, emacs-devel@gnu.org, storm@cua.dk To: jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 19:50:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUoqN-00025U-Po for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 19:50:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUosJ-0008Vd-6a for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 13:52:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUosG-0008UK-76 for emacs-devel@gnu.org; Fri, 23 Mar 2007 14:52:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUosD-0008U0-Pi for emacs-devel@gnu.org; Fri, 23 Mar 2007 14:52:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUosD-0008Tx-K8 for emacs-devel@gnu.org; Fri, 23 Mar 2007 13:52:25 -0500 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1HUoqF-0005eU-Ru; Fri, 23 Mar 2007 14:50:24 -0400 Original-Received: from jane.dms.auburn.edu (jane.dms.auburn.edu [131.204.53.201]) by manatee.dms.auburn.edu (8.13.7+Sun/8.13.7) with ESMTP id l2NIo3vv012060; Fri, 23 Mar 2007 13:50:04 -0500 (CDT) Original-Received: from jane.dms.auburn.edu (localhost [127.0.0.1]) by jane.dms.auburn.edu (8.13.4+Sun/8.13.4) with ESMTP id l2NIm2tg019280; Fri, 23 Mar 2007 13:48:02 -0500 (CDT) Original-Received: (from teirllm@localhost) by jane.dms.auburn.edu (8.13.4+Sun/8.13.3/Submit) id l2NIm1Je019277; Fri, 23 Mar 2007 13:48:01 -0500 (CDT) X-Authentication-Warning: jane.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f In-reply-to: <46040576.9090505@gnu.org> (message from Jason Rumney on Fri, 23 Mar 2007 16:51:02 +0000) X-detected-kernel: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68429 Archived-At: Jason Rumney wrote: I'm not sure, do we really expect buffer-size to be the same as the number of bytes in the file, potentially in the presence of multibyte characters? Of course not and I actually got files for which the two are very different. This change is quite likely to break things if that assumption is not correct. Could cause 100% CPU usage and continuous overshouting of other minibuffer messages with revert messages, making Emacs completely unusable. On top of that, if Emacs has trouble checking when a file has changed on disk on MS Windows, then how is this a problem that is specific to Auto Revert Mode? What about any other part of Emacs that needs to know this? Sincerely, Luc Teirlinck.