abbrev file and -batch

abbrev file and -batch

[Dan Nicolaescu]

I got an error when using "sudo" to build an emacs rpm. (i.e. "sudo root")
The error looks like this:

../src/bootstrap-emacs -batch --no-site-file --multibyte -l autoload --eval '(setq generated-autoload-file "/usr/src/redhat/BUILD/emacs-22.0.93/lisp/loaddefs.el")' -f batch-update-autoloads $wins
Directories: /usr/src/redhat/BUILD/emacs-22.0.93/lisp/. /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./net /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./mh-e /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./calendar /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./progmodes /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./eshell /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./erc /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./mail /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./language /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./emacs-lisp /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./calc /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./gnus /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./textmodes /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./international /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./emulation /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./url /usr/src/redhat/BUILD/emacs-22.0.93/lisp/./play
Cannot open load file: ~/.abbrev_defs
make[2]: *** [autoloads] Error 255
make[2]: Leaving directory `/usr/src/redhat/BUILD/emacs-22.0.93/lisp'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/usr/src/redhat/BUILD/emacs-22.0.93'
make: *** [bootstrap] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.82722 (%build)

The problem is that the permissions for ~/.abbrev_defs (which is ~dann/.abbrev_defs) are -rw------- 
~ is NFS mounted, so ~/.abbrev_defs is not readable when using "sudo"

The test for abbrev-file-name in startup.el can be changed from:
  (if (file-exists-p abbrev-file-name)
to
  (if (and (file-exists-p abbrev-file-name) (file-readable-p abbrev-file-name))

But also, should the abbrev file even be loaded when using -batch ? 

Re: abbrev file and -batch

[Richard Stallman]

    The test for abbrev-file-name in startup.el can be changed from:
      (if (file-exists-p abbrev-file-name)
    to
      (if (and (file-exists-p abbrev-file-name) (file-readable-p abbrev-file-name))

    But also, should the abbrev file even be loaded when using -batch ? 

I think it should not be.  But maybe we should not risk changing that now.
Let's install your patch instead, and make a note to turn it off
entirely in the -batch case after the release.

Can you install that?

Re: abbrev file and -batch

[Dan Nicolaescu]

Richard Stallman <rms@gnu.org> writes:

  >     The test for abbrev-file-name in startup.el can be changed from:
  >       (if (file-exists-p abbrev-file-name)
  >     to
  >       (if (and (file-exists-p abbrev-file-name) (file-readable-p abbrev-file-name))
  > 
  >     But also, should the abbrev file even be loaded when using -batch ? 
  > 
  > I think it should not be.  But maybe we should not risk changing that now.
  > Let's install your patch instead, and make a note to turn it off
  > entirely in the -batch case after the release.
  > 
  > Can you install that?

Done.