From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.devel Subject: Re: SVG support in Emacs: what happened? Date: Sat, 20 Jan 2007 21:48:48 +0200 Message-ID: <200701202148.48378.pogonyshev@gmx.net> References: <1169200808.6510.7.camel@galahad> <200701200210.34542.pogonyshev@gmx.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1169322181 6695 80.91.229.12 (20 Jan 2007 19:43:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 20 Jan 2007 19:43:01 +0000 (UTC) Cc: bhawkeslewis@googlemail.com, rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 20 20:42:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H8M75-0004Oe-Oc for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2007 20:42:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H8M76-0007PI-DT for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2007 14:42:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H8M6P-0007Dl-MG for emacs-devel@gnu.org; Sat, 20 Jan 2007 14:42:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H8M6O-0007DP-PX for emacs-devel@gnu.org; Sat, 20 Jan 2007 14:42:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H8M6O-0007DK-M8 for emacs-devel@gnu.org; Sat, 20 Jan 2007 14:42:12 -0500 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.52) id 1H8M6O-0006WJ-1K for emacs-devel@gnu.org; Sat, 20 Jan 2007 14:42:12 -0500 Original-Received: (qmail invoked by alias); 20 Jan 2007 19:42:11 -0000 Original-Received: from unknown (EHLO [80.94.234.138]) [80.94.234.138] by mail.gmx.net (mp032) with SMTP; 20 Jan 2007 20:42:11 +0100 X-Authenticated: #16844820 Original-To: emacs-devel@gnu.org, Eli Zaretskii User-Agent: KMail/1.7.2 In-Reply-To: Content-Disposition: inline X-Y-GMX-Trusted: 0 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65328 Archived-At: Eli Zaretskii wrote: > > From: Paul Pogonyshev > > Date: Sat, 20 Jan 2007 02:10:34 +0200 > > Cc: Benjamin Hawkes-Lewis , rms@gnu.org > > > > > > 1. What does the code need to make it "portable"? > > > > Probably input of someone on Windows. I'm sure it won't compile there > > simply because I made no effort for this. > > The patch indeed needs some work to avoid breaking the Windows port. > As posted, the patch will try to compile the SVG code unconditionally, > since it uses very strange conditionals to enable SVG: > > #if 1 || defined (HAVE_RSVG) I added this because I didn't run `autoconf' or `autoheader, it was mentioned in my message. Of course it should be replaced with a proper condition. Also, drawing code is not portable and was adapted from some existing code for X. Don't remember which exactly. > One other issue would be to see whether the configure test is okay. > For example, do we really want to use pkg-config for that? do all > platforms that have SVG also have pkg-config? AFAIK, librsvg tests for pkg-config in its own `configure' script. > > > 3. Is Paul (or anyone else) (in 2007) "willing to have a try" at turning > > > it from a "first shot" into a final patch? > > > > Not as I know. I'm not going to work on it until Emacs trunk is > > "unfrozen". It might as well take another year or two, so it is > > meaningless for me (as not a core Emacs developer) to spend time on it. > > FWIW, I don't think we should add this code during the pretest. Sure we shouldn't. I just wish pretest doesn't take forever. Paul