From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tak Ota Newsgroups: gmane.emacs.devel Subject: Re: momentary-string-display Date: Wed, 03 Jan 2007 13:36:14 -0800 (PST) Organization: Sony Electronics Inc. Message-ID: <20070103.133614.261709134.Takaaki.Ota@am.sony.com> References: <20070102.145456.91281212.Takaaki.Ota@am.sony.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Wed_Jan_03_13_36_14_2007_769)--" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1167860257 4724 80.91.229.12 (3 Jan 2007 21:37:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 Jan 2007 21:37:37 +0000 (UTC) Cc: lekktu@gmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 03 22:37:34 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H2DnX-0005VI-H6 for ged-emacs-devel@m.gmane.org; Wed, 03 Jan 2007 22:37:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2DnW-0002B0-Rh for ged-emacs-devel@m.gmane.org; Wed, 03 Jan 2007 16:37:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H2Dmn-0001nP-2C for emacs-devel@gnu.org; Wed, 03 Jan 2007 16:36:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H2Dmm-0001mV-5k for emacs-devel@gnu.org; Wed, 03 Jan 2007 16:36:36 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2Dml-0001mJ-UX for emacs-devel@gnu.org; Wed, 03 Jan 2007 16:36:35 -0500 Original-Received: from [207.46.163.16] (helo=outbound2-cpk-R.bigfish.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1H2Dmj-0000Pc-5v; Wed, 03 Jan 2007 16:36:33 -0500 Original-Received: from outbound2-cpk.bigfish.com (localhost.localdomain [127.0.0.1]) by outbound2-cpk-R.bigfish.com (Postfix) with ESMTP id 58901E9171D; Wed, 3 Jan 2007 21:36:23 +0000 (UTC) Original-Received: from mail117-cpk-R.bigfish.com (unknown [192.168.21.3]) by outbound2-cpk.bigfish.com (Postfix) with ESMTP id 4D287E916F0; Wed, 3 Jan 2007 21:36:23 +0000 (UTC) Original-Received: from mail117-cpk.bigfish.com (localhost.localdomain [127.0.0.1]) by mail117-cpk-R.bigfish.com (Postfix) with ESMTP id C34835D46F1; Wed, 3 Jan 2007 21:36:21 +0000 (UTC) X-BigFish: V Original-Received: by mail117-cpk (MessageSwitch) id 1167860181726158_7715; Wed, 3 Jan 2007 21:36:21 +0000 (UCT) Original-Received: from mail8.fw-sd.sony.com (mail8.fw-sd.sony.com [160.33.66.75]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mail117-cpk.bigfish.com (Postfix) with ESMTP id 62A8E5DB3DB; Wed, 3 Jan 2007 21:36:21 +0000 (UTC) Original-Received: from mail1.sgo.in.sel.sony.com (mail1.sgo.in.sel.sony.com [43.130.1.111]) by mail8.fw-sd.sony.com (8.12.11/8.12.11) with ESMTP id l03LaFuM007859; Wed, 3 Jan 2007 21:36:15 GMT Original-Received: from localhost (us00130290172a.am.sony.com [43.191.14.104]) by mail1.sgo.in.sel.sony.com (8.12.11/8.12.11) with ESMTP id l03LaFhH028597; Wed, 3 Jan 2007 21:36:15 GMT Original-To: rms@gnu.org In-Reply-To: X-Telephone: +1-858-942-3239 X-Fax------: +1-858-942-9142 X-SnailMail: 16450 West Bernardo Drive MZ7205, San Diego, CA 92127-1804 X-Mailer: Mew-5.2rc2 on Emacs-22.0.92.1 (i386-mingw-nt5.1.2600 built on 2007-01-02) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64716 Archived-At: ----Next_Part(Wed_Jan_03_13_36_14_2007_769)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Wed, 03 Jan 2007 16:11:01 -0500: Richard Stallman wrote: > > I see two uses of momentary-string-display in table.el which perhaps > > should be replaced by calls to display-warning. > > Takaaki-san, do you think that is a good idea? > > I compared the behavior of the two functions and I prefer > momentary-string-display. However, I don't object replacing it with > display-warning. > > Would you please do that, for the two uses in table.el? > Sure. Could you have someone check in the attached patch? -Tak 2007-01-03 Takaaki Ota * textmodes/table.el (table--warn-incompatibility): replace all momentary-string-display with display-warning. ----Next_Part(Wed_Jan_03_13_36_14_2007_769)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="table.patch" *** emacs-22.0.91/lisp/textmodes/table.el Wed Jan 3 13:29:35 2007 --- ../../../emacs/emacs-22.0.91/lisp/textmodes/table.el Wed Jan 3 13:23:46 2007 *************** *** 6,12 **** ;; Keywords: wp, convenience ;; Author: Takaaki Ota ;; Created: Sat Jul 08 2000 13:28:45 (PST) ! ;; Revised: Thu Jul 20 2006 17:30:09 (PDT) ;; This file is part of GNU Emacs. --- 6,12 ---- ;; Keywords: wp, convenience ;; Author: Takaaki Ota ;; Created: Sat Jul 08 2000 13:28:45 (PST) ! ;; Revised: Wed Jan 03 2007 13:23:46 (PST) ;; This file is part of GNU Emacs. *************** *** 5358,5364 **** (cond ((and (featurep 'xemacs) (not (get 'table-disable-incompatibility-warning 'xemacs))) (put 'table-disable-incompatibility-warning 'xemacs t) ! (momentary-string-display " *** Warning *** --- 5358,5364 ---- (cond ((and (featurep 'xemacs) (not (get 'table-disable-incompatibility-warning 'xemacs))) (put 'table-disable-incompatibility-warning 'xemacs t) ! (display-warning 'table " *** Warning *** *************** *** 5369,5380 **** aware of this. " ! (save-excursion (forward-line 1) (point)))) ((and (boundp 'flyspell-mode) flyspell-mode (not (get 'table-disable-incompatibility-warning 'flyspell))) (put 'table-disable-incompatibility-warning 'flyspell t) ! (momentary-string-display " *** Warning *** --- 5369,5380 ---- aware of this. " ! :warning)) ((and (boundp 'flyspell-mode) flyspell-mode (not (get 'table-disable-incompatibility-warning 'flyspell))) (put 'table-disable-incompatibility-warning 'flyspell t) ! (display-warning 'table " *** Warning *** *************** *** 5383,5389 **** works better than the previous versions however not fully compatible. " ! (save-excursion (forward-line 1) (point)))) ))) (defun table--cell-blank-str (&optional n) --- 5383,5389 ---- works better than the previous versions however not fully compatible. " ! :warning)) ))) (defun table--cell-blank-str (&optional n) ----Next_Part(Wed_Jan_03_13_36_14_2007_769)-- Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel ----Next_Part(Wed_Jan_03_13_36_14_2007_769)----