From: Tak Ota <Takaaki.Ota@am.sony.com>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: momentary-string-display
Date: Wed, 03 Jan 2007 13:36:14 -0800 (PST) [thread overview]
Message-ID: <20070103.133614.261709134.Takaaki.Ota@am.sony.com> (raw)
In-Reply-To: <E1H2DO1-0003DZ-1i@fencepost.gnu.org>
[-- Attachment #1: Type: Text/Plain, Size: 723 bytes --]
Wed, 03 Jan 2007 16:11:01 -0500: Richard Stallman <rms@gnu.org> wrote:
> > I see two uses of momentary-string-display in table.el which perhaps
> > should be replaced by calls to display-warning.
> > Takaaki-san, do you think that is a good idea?
>
> I compared the behavior of the two functions and I prefer
> momentary-string-display. However, I don't object replacing it with
> display-warning.
>
> Would you please do that, for the two uses in table.el?
>
Sure. Could you have someone check in the attached patch?
-Tak
2007-01-03 Takaaki Ota <Takaaki.Ota@am.sony.com>
* textmodes/table.el (table--warn-incompatibility): replace all
momentary-string-display with display-warning.
[-- Attachment #2: table.patch --]
[-- Type: Text/Plain, Size: 2175 bytes --]
*** emacs-22.0.91/lisp/textmodes/table.el Wed Jan 3 13:29:35 2007
--- ../../../emacs/emacs-22.0.91/lisp/textmodes/table.el Wed Jan 3 13:23:46 2007
***************
*** 6,12 ****
;; Keywords: wp, convenience
;; Author: Takaaki Ota <Takaaki.Ota@am.sony.com>
;; Created: Sat Jul 08 2000 13:28:45 (PST)
! ;; Revised: Thu Jul 20 2006 17:30:09 (PDT)
;; This file is part of GNU Emacs.
--- 6,12 ----
;; Keywords: wp, convenience
;; Author: Takaaki Ota <Takaaki.Ota@am.sony.com>
;; Created: Sat Jul 08 2000 13:28:45 (PST)
! ;; Revised: Wed Jan 03 2007 13:23:46 (PST)
;; This file is part of GNU Emacs.
***************
*** 5358,5364 ****
(cond ((and (featurep 'xemacs)
(not (get 'table-disable-incompatibility-warning 'xemacs)))
(put 'table-disable-incompatibility-warning 'xemacs t)
! (momentary-string-display
"
*** Warning ***
--- 5358,5364 ----
(cond ((and (featurep 'xemacs)
(not (get 'table-disable-incompatibility-warning 'xemacs)))
(put 'table-disable-incompatibility-warning 'xemacs t)
! (display-warning 'table
"
*** Warning ***
***************
*** 5369,5380 ****
aware of this.
"
! (save-excursion (forward-line 1) (point))))
((and (boundp 'flyspell-mode)
flyspell-mode
(not (get 'table-disable-incompatibility-warning 'flyspell)))
(put 'table-disable-incompatibility-warning 'flyspell t)
! (momentary-string-display
"
*** Warning ***
--- 5369,5380 ----
aware of this.
"
! :warning))
((and (boundp 'flyspell-mode)
flyspell-mode
(not (get 'table-disable-incompatibility-warning 'flyspell)))
(put 'table-disable-incompatibility-warning 'flyspell t)
! (display-warning 'table
"
*** Warning ***
***************
*** 5383,5389 ****
works better than the previous versions however not fully compatible.
"
! (save-excursion (forward-line 1) (point))))
)))
(defun table--cell-blank-str (&optional n)
--- 5383,5389 ----
works better than the previous versions however not fully compatible.
"
! :warning))
)))
(defun table--cell-blank-str (&optional n)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
prev parent reply other threads:[~2007-01-03 21:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 1:18 momentary-string-display Juanma Barranquero
2006-12-27 21:16 ` momentary-string-display Richard Stallman
2006-12-27 23:53 ` momentary-string-display Juanma Barranquero
2006-12-29 15:44 ` momentary-string-display Richard Stallman
2007-01-02 23:58 ` momentary-string-display Juanma Barranquero
2006-12-29 4:47 ` momentary-string-display Kevin Rodgers
2006-12-29 22:58 ` momentary-string-display Richard Stallman
2007-01-03 8:53 ` momentary-string-display Kevin Rodgers
2007-01-04 1:41 ` momentary-string-display Stephen Leake
2007-01-04 2:31 ` momentary-string-display Richard Stallman
2007-01-04 15:31 ` momentary-string-display Kevin Rodgers
2007-01-04 22:34 ` momentary-string-display Richard Stallman
2007-01-04 23:18 ` momentary-string-display Juanma Barranquero
2007-01-05 19:09 ` momentary-string-display Richard Stallman
2007-01-05 7:05 ` momentary-string-display Stephen Leake
2007-01-06 2:54 ` momentary-string-display Richard Stallman
2007-01-06 7:36 ` momentary-string-display Stephen Leake
2007-01-07 3:47 ` momentary-string-display Richard Stallman
2007-01-07 14:41 ` momentary-string-display Stephen Leake
2007-01-02 22:54 ` momentary-string-display Tak Ota
2007-01-03 21:11 ` momentary-string-display Richard Stallman
2007-01-03 21:36 ` Tak Ota [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070103.133614.261709134.Takaaki.Ota@am.sony.com \
--to=takaaki.ota@am.sony.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).