unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Masatake YAMATO <jet@gyve.org>
Cc: herberteuler@hotmail.com, emacs-devel@gnu.org
Subject: Re: Some problems in `add-log-current-defun'
Date: Sat, 30 Dec 2006 13:55:40 +0900 (JST)	[thread overview]
Message-ID: <20061230.135540.151586663.jet@gyve.org> (raw)
In-Reply-To: <E1H0JuO-0005Uo-Fv@fencepost.gnu.org>

>     >     void ssort(void * base, size_t n, size_t sz, CFT cmp)
>     >     /*
>     >         Sort the "n" elements of vector "base" into increasing order
>     >         using the comparison function pointed to by "cmp".
>     >         The elements are of size "sz".
>     > 
>     >         Shell sort (Knuth, Vol3, pg84)
>     >     */
>     >     {
>     >         /* ...  */
>     >     }
>     > 
>     > That seems like common usage -- not weird.  It would be nice to handle
>     > that usage correctly.  However, if we have never handled it in the
>     > past, I think it is not urgent to fix it now.
>     > 
>     > Masatake YAMATO <jet@gyve.org> thinks that code is badly formatted.
>     > Masatake, why do you think so?
> 
>     Just because I have never seen such a comment style.
> 
> 
> The comment looks ordinary to me.  It starts with /* at the start of a
> line, and ends with */ on a separate line.
> 
> Do you mean the POSITION of the comment is unusual?

Yes. A comment put between a function signature( void ssort(void * base, size_t n, size_t sz, CFT cmp) )
and its body is unusual for me.

Masatake YAMATO

  reply	other threads:[~2006-12-30  4:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-27 10:32 Some problems in `add-log-current-defun' Herbert Euler
2006-12-27 10:45 ` David Kastrup
2006-12-27 11:48   ` Masatake YAMATO
2006-12-27 12:22     ` David Kastrup
2006-12-27 11:55 ` Masatake YAMATO
2006-12-27 13:46 ` Masatake YAMATO
2006-12-27 21:17 ` Richard Stallman
2006-12-28 12:41   ` Masatake YAMATO
2006-12-29 15:44     ` Richard Stallman
2006-12-30  4:55       ` Masatake YAMATO [this message]
2006-12-30 18:24         ` Richard Stallman
2006-12-28 12:47   ` Herbert Euler
2006-12-29 15:44     ` Richard Stallman
2006-12-29  3:10   ` Herbert Euler
  -- strict thread matches above, loose matches on Subject: below --
2006-12-31  8:28 Herbert Euler
2006-12-31 22:13 ` Richard Stallman
2007-01-01  1:27   ` Herbert Euler
2007-01-02 23:35   ` Stefan Monnier
2007-01-03 21:11     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061230.135540.151586663.jet@gyve.org \
    --to=jet@gyve.org \
    --cc=emacs-devel@gnu.org \
    --cc=herberteuler@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).