From: Masatake YAMATO <jet@gyve.org>
Cc: emacs-devel@gnu.org
Subject: Re: Some problems in `add-log-current-defun'
Date: Wed, 27 Dec 2006 20:55:34 +0900 (JST) [thread overview]
Message-ID: <20061227.205534.82897855.jet@gyve.org> (raw)
In-Reply-To: <BAY112-F34477621BF3C6EE6E473DBDAC00@phx.gbl>
About II. I'd like to hear a comment from David.
> I. The end of a function
>
> The point is moved to the start position of a function or an empty
> line (lines consist of only white space characters) with the following
> code.
>
> ;; See if we are in the beginning part of a function,
> ;; before the open brace. If so, advance forward.
> (while (not (looking-at "{\\|\\(\\s *$\\)"))
> (forward-line 1))
>
> But this is not reliable. If someone forgets to put a newline after a
> function, `add-log-current-defun' will report wrong name. Please
> consider the following example:
>
> int
> f1 ()
> {
> /* If point is here `add-log-current-defun' gets wrong result. */
> }
> int
> f2 ()
> {
> /* ... */
> }
>
> When the point is inside the body of `f1', invoking
> `add-log-current-defun' will get `f2', rather than `f1'.
Reproduced. I think this is case that `add-log-current-defun' cannot handle
reasonably formatted C++ code.
> III. Different styles
>
> The function skips typedefs and arglist with the following forms.
>
> ;; Skip back over typedefs and arglist.
> ;; Stop at the function definition itself
> ;; or at the line that follows end of function doc string.
> (forward-line -1)
> (while (and (not (bobp))
> (looking-at "[ \t\n]")
> (not (looking-back "[*]/)\n" (- (point) 4))))
> (forward-line -1))
>
> This is not general: it cannot process programs in some style. In
> section 7.7 of the 3rd edition of The C++ Programming Language by
> Bjarne Stroustrup, there is a shell sort implementation:
>
> void ssort(void * base, size_t n, size_t sz, CFT cmp)
> /*
> Sort the "n" elements of vector "base" into increasing order
> using the comparison function pointed to by "cmp".
> The elements are of size "sz".
>
> Shell sort (Knuth, Vol3, pg84)
> */
> {
> /* ... */
> }
>
> The current implementation cannot handle programs in this style
> correctly.
The book is very famous. However, in my experience this code is not
reasonably formatted.
> And what I tried to fix is not general too. My fix is
>
> (while (not (looking-back "\\(^\\|[ \t]\\)"))
> (forward-sexp -1))
>
> This is not general too: C++ permits the nested name to be put in many
> lines. For example, the following name is valid:
>
> void
> class_1
> ::
> sub_class_2
> ::
> method_3 ()
> {
> /* ... */
> }
>
> The current implementation cannot handle this name correctly.
I think this is also not reasonably formatted.
Masatake YAMATO
next prev parent reply other threads:[~2006-12-27 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 10:32 Some problems in `add-log-current-defun' Herbert Euler
2006-12-27 10:45 ` David Kastrup
2006-12-27 11:48 ` Masatake YAMATO
2006-12-27 12:22 ` David Kastrup
2006-12-27 11:55 ` Masatake YAMATO [this message]
2006-12-27 13:46 ` Masatake YAMATO
2006-12-27 21:17 ` Richard Stallman
2006-12-28 12:41 ` Masatake YAMATO
2006-12-29 15:44 ` Richard Stallman
2006-12-30 4:55 ` Masatake YAMATO
2006-12-30 18:24 ` Richard Stallman
2006-12-28 12:47 ` Herbert Euler
2006-12-29 15:44 ` Richard Stallman
2006-12-29 3:10 ` Herbert Euler
-- strict thread matches above, loose matches on Subject: below --
2006-12-31 8:28 Herbert Euler
2006-12-31 22:13 ` Richard Stallman
2007-01-01 1:27 ` Herbert Euler
2007-01-02 23:35 ` Stefan Monnier
2007-01-03 21:11 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227.205534.82897855.jet@gyve.org \
--to=jet@gyve.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).