OpenBSD build failure

OpenBSD build failure

[Alfred M. Szmidt]

The build failure that I reported in the beginning of November wasn't
fixed (probobly due me not testing the patch).  I have no tested it,
and emacs builds fine on OpenBSD with it.  It follows Richards
suggestion to set LD_SWITCH_X_DEFAULT instead of LD_SWITCH_SYSTEM.
Could someone apply it, please?

2006-11-02  Alfred M. Szmidt  <ams@gnu.org>  (tiny change)

	* s/openbsd.h (LD_SWITCH_SYSTEM): Remove /usr/pkg/lib and
	/usr/pkg/lib from the library search path.
	(LD_SWITCH_X_DEFAULT): New macro.

Index: openbsd.h
===================================================================
RCS file: /cvsroot/emacs/emacs/src/s/openbsd.h,v
retrieving revision 1.8
diff -u -p -r1.8 src/s/openbsd.h
*** src/s/openbsd.h	30 Oct 2006 23:05:35 -0000	1.8
--- src/s/openbsd.h	2 Nov 2006 14:05:03 -0000
***************
*** 23,33 ****
  
  /*  Han Boetes <han@mijncomputer.nl> says this
      is necessary,  otherwise Emacs dumps core on elf systems.  */
! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -Z -L/usr/pkg/lib -L/usr/local/lib
  
  #else
  
! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -L/usr/pkg/lib -L/usr/local/lib
  
  #endif
  
--- 24,40 ----
  
  /*  Han Boetes <han@mijncomputer.nl> says this
      is necessary,  otherwise Emacs dumps core on elf systems.  */
! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -Z
! 
! /* The version of gcc on OpenBSD doesn't search /usr/local/lib by
!    default.  */
! #define LD_SWITCH_X_DEFAULT -L/usr/local/lib
  
  #else
  
! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp
! 
! #define LD_SWITCH_X_DEFAULT -L/usr/local/lib
  
  #endif

Re: OpenBSD build failure

[Chong Yidong]

"Alfred M. Szmidt" <ams@gnu.org> writes:

> The build failure that I reported in the beginning of November wasn't
> fixed (probobly due me not testing the patch).  I have no tested it,
> and emacs builds fine on OpenBSD with it.  It follows Richards
> suggestion to set LD_SWITCH_X_DEFAULT instead of LD_SWITCH_SYSTEM.
> Could someone apply it, please?

Applied.  (So we don't need to include /usr/pkg/lib in the ld switches
at all?)

> 2006-11-02  Alfred M. Szmidt  <ams@gnu.org>  (tiny change)
>
> 	* s/openbsd.h (LD_SWITCH_SYSTEM): Remove /usr/pkg/lib and
> 	/usr/pkg/lib from the library search path.
> 	(LD_SWITCH_X_DEFAULT): New macro.
>
> Index: openbsd.h
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/s/openbsd.h,v
> retrieving revision 1.8
> diff -u -p -r1.8 src/s/openbsd.h
> *** src/s/openbsd.h	30 Oct 2006 23:05:35 -0000	1.8
> --- src/s/openbsd.h	2 Nov 2006 14:05:03 -0000
> ***************
> *** 23,33 ****
>   
>   /*  Han Boetes <han@mijncomputer.nl> says this
>       is necessary,  otherwise Emacs dumps core on elf systems.  */
> ! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -Z -L/usr/pkg/lib -L/usr/local/lib
>   
>   #else
>   
> ! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -L/usr/pkg/lib -L/usr/local/lib
>   
>   #endif
>   
> --- 24,40 ----
>   
>   /*  Han Boetes <han@mijncomputer.nl> says this
>       is necessary,  otherwise Emacs dumps core on elf systems.  */
> ! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp -Z
> ! 
> ! /* The version of gcc on OpenBSD doesn't search /usr/local/lib by
> !    default.  */
> ! #define LD_SWITCH_X_DEFAULT -L/usr/local/lib
>   
>   #else
>   
> ! #define LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_tmp
> ! 
> ! #define LD_SWITCH_X_DEFAULT -L/usr/local/lib
>   
>   #endif

Re: OpenBSD build failure

[Alfred M. Szmidt]

   Applied.  

Thank you.

   (So we don't need to include /usr/pkg/lib in the ld switches at
   all?)

No, since /usr/pkg/lib does not exist on OpenBSD.  Locally installed
packages always get installed in /usr/local.