From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: Minor src/xmenu.c change for older GCC versions Date: Sun, 5 Nov 2006 15:18:08 +0200 Message-ID: <20061105131808.GA95583@kobe.laptop> References: <200611032150.kA3Locm0078547@kobe.laptop> <87psc328yh.fsf@stupidchicken.com> <20061105080057.GA15931@kobe.laptop> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1162732759 22508 80.91.229.2 (5 Nov 2006 13:19:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2006 13:19:19 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 05 14:19:17 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gghu6-0006yy-V3 for ged-emacs-devel@m.gmane.org; Sun, 05 Nov 2006 14:19:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gghu6-0003fS-Em for ged-emacs-devel@m.gmane.org; Sun, 05 Nov 2006 08:19:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gghtw-0003fN-6j for emacs-devel@gnu.org; Sun, 05 Nov 2006 08:19:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gghtu-0003fB-JU for emacs-devel@gnu.org; Sun, 05 Nov 2006 08:19:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gghtu-0003f8-HD for emacs-devel@gnu.org; Sun, 05 Nov 2006 08:19:02 -0500 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gghtt-0006r2-8F; Sun, 05 Nov 2006 08:19:01 -0500 Original-Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id kA5DITQI004667 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 5 Nov 2006 15:18:52 +0200 Original-Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id kA5DICVf095601; Sun, 5 Nov 2006 15:18:16 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id kA5DI9ON095600; Sun, 5 Nov 2006 15:18:09 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-To: Eli Zaretskii Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.529, required 5, AWL -0.13, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61821 Archived-At: On 2006-11-05 14:06, Eli Zaretskii wrote: >>Date: Sun, 5 Nov 2006 10:00:57 +0200 >>From: Giorgos Keramidas >>Cc: Chong Yidong , emacs-devel@gnu.org >>> >>> Please add a comment explaining why this is necessary, to make sure >>> people don't take this out for elegance's sake. >> >> Good point. Sorry I didn't add a comment originally. I thought >> mentioning it in the commit log would be sufficient for now :) > > It's actually the other way around: the ChangeLog entry should only > tell WHAT has been changed; the WHY should be in the comments to the > code. See the GNU coding standards for more about this. I see. I've worked mostly with FreeBSD sources, where follow the reverse principle. The commit logs keep the WHY of each change there. I'll have to reread the GNU coding standards. Thanks for the explanation :)