From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Minor src/xmenu.c change for older GCC versions Date: Fri, 3 Nov 2006 23:50:38 +0200 (EET) Message-ID: <200611032150.kA3Locm0078547@kobe.laptop> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1162590713 15653 80.91.229.2 (3 Nov 2006 21:51:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2006 21:51:53 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 22:51:49 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gg6wW-0003tt-1Q for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 22:51:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gg6wV-00034p-Ma for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 16:51:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gg6wM-00034a-65 for emacs-devel@gnu.org; Fri, 03 Nov 2006 16:51:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gg6wL-00034O-NQ for emacs-devel@gnu.org; Fri, 03 Nov 2006 16:51:05 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gg6wL-00034L-LC for emacs-devel@gnu.org; Fri, 03 Nov 2006 16:51:05 -0500 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gg6wL-0005ak-E0 for emacs-devel@gnu.org; Fri, 03 Nov 2006 16:51:05 -0500 Original-Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id kA3Lompr028176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 3 Nov 2006 23:50:49 +0200 Original-Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id kA3LocIh078550 for ; Fri, 3 Nov 2006 23:50:41 +0200 (EET) (envelope-from keramida@kobe.laptop) Original-Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id kA3Locm0078547; Fri, 3 Nov 2006 23:50:38 +0200 (EET) (envelope-from keramida) Original-To: emacs-devel@gnu.org X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.033, required 5, AWL -1.64, BAYES_00 -2.60, NO_DNS_FOR_FROM 3.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61723 Archived-At: On FreeBSD 4.X we use GCC 2.95.4 20020320 [FreeBSD] as the system compiler. The src/xmenu.c source triggers an error when compiled with this version of GCC, so we had to make the following local change as part of the editors/emacs-devel port of Emacs 22.X to FreeBSD: %%% diff -r e9c18eba38ea -r 355e6a7d786b src/xmenu.c --- a/src/xmenu.c Fri Oct 27 15:45:51 2006 +0000 +++ b/src/xmenu.c Sat Oct 28 01:49:45 2006 +0300 @@ -1395,9 +1395,10 @@ If FRAME is nil or not given, use the se Lisp_Object frame; { GtkWidget *menubar; + FRAME_PTR f; + BLOCK_INPUT; - FRAME_PTR f = check_x_frame (frame); - + f = check_x_frame (frame); if (FRAME_EXTERNAL_MENU_BAR (f)) set_frame_menubar (f, 0, 1); %%% Apparently, gcc 2.95.4 does not accept the FRAME_PTR declaration *after* BLOCK_INPUT, because it expects all declarations to come before BLOCK_INPUT expands to executable parts. Does this change look like something we can add to Emacs before pretest gets released? It's not really that intrusive, and it will reduce the number of local patches we have to use to build Emacs 22.X on FreeBSD, when it's officially released. Regards, Giorgos