Re: Emacs and GFortran

[Steve Kargl <sgk@troutmask.apl.washington.edu>]

On Fri, Nov 03, 2006 at 02:08:17AM +0100, Alfred M. Szmidt wrote:
> 
> I volunteered.  And now you are calling me of all people hostile and
> on top of that ignorant? The fix in question is so trivial that it
> takes more time to read your message than actually fixing it!  Steve
> Kargl might have not been very cooperative

Alfred has asked me not to respond to him, so I've removed
him from the list.

I have stated more than once THE TRIVIAL FIX DOES NOT WORK.
It causes REGRESSIONS in the gfortran testsuite.  If someone
wants to fix whatever is causing the regressions, I'll be more
than happy to commit the patch.

This patch 

troutmask:sgk[119] svn diff error.c
Index: error.c
===================================================================
--- error.c     (revision 118397)
+++ error.c     (working copy)
@@ -134,7 +134,7 @@ show_locus (int offset, locus * loc)
 
   lb = loc->lb;
   f = lb->file;
-  error_printf ("In file %s:%d\n", f->filename,
+  error_printf ("%s:%d\n", f->filename,
 #ifdef USE_MAPPED_LOCATION
                LOCATION_LINE (lb->location)
 #else


causes over 2000 regressions of the form


Executing on host: /usr/home/sgk/gcc/obj4x/gcc/testsuite/gfortran/../../gfortran
 -B/usr/home/sgk/gcc/obj4x/gcc/testsuite/gfortran/../../ /usr/home/sgk/gcc/gcc4x
/gcc/testsuite/gfortran.dg/PR19754_1.f90   -O   -pedantic-errors -S  -o PR19754_
1.s    (timeout = 300)
 /usr/home/sgk/gcc/gcc4x/gcc/testsuite/gfortran.dg/PR19754_1.f90:7

   x = x + y ! { dg-error "Shapes for operands at" }
      1    2
Error: Shapes for operands at (1) and (2) are not conformable
compiler exited with status 1
output is:
 /usr/home/sgk/gcc/gcc4x/gcc/testsuite/gfortran.dg/PR19754_1.f90:7

   x = x + y ! { dg-error "Shapes for operands at" }
      1    2
Error: Shapes for operands at (1) and (2) are not conformable

FAIL: gfortran.dg/PR19754_1.f90  -O   (test for errors, line 7)
FAIL: gfortran.dg/PR19754_1.f90  -O  (test for excess errors)
Excess errors:
 /usr/home/sgk/gcc/gcc4x/gcc/testsuite/gfortran.dg/PR19754_1.f90:7
   x = x + y ! { dg-error "Shapes for operands at" }
      1    2
Error: Shapes for operands at (1) and (2) are not conformable

-- 
Steve