From: Giorgos Keramidas <keramida@ceid.upatras.gr>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
Date: Thu, 12 Oct 2006 16:12:32 +0300 [thread overview]
Message-ID: <20061012131232.GA8507@gothmog.pc> (raw)
In-Reply-To: <je64epr995.fsf@sykes.suse.de>
On 2006-10-12 14:47, Andreas Schwab <schwab@suse.de> wrote:
>Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>> It seems to include this part:
>>
>> + if [ ! -d ${INSTALLDIR} ] ; then \
>> + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> + else true; fi
>>
>> We don't really *need* to have an else branch in all statements. We can
>> write this as:
>>
>> + if [ ! -d ${INSTALLDIR} ] ; then \
>> + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> + fi
>
> Except that some old shells will cause the whole command to fail if the
> condition fails.
I see. I didn't know about this. Thanks for the clarification :)
next prev parent reply other threads:[~2006-10-12 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 23:22 [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Giorgos Keramidas
2006-10-12 0:31 ` Giorgos Keramidas
2006-10-12 5:59 ` Kenichi Handa
2006-10-12 12:35 ` Giorgos Keramidas
2006-10-12 12:47 ` Andreas Schwab
2006-10-12 13:12 ` Giorgos Keramidas [this message]
2006-10-12 12:52 ` David Kastrup
2006-10-12 13:10 ` Kenichi Handa
2006-10-12 13:13 ` Giorgos Keramidas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012131232.GA8507@gothmog.pc \
--to=keramida@ceid.upatras.gr \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).