From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Date: Thu, 12 Oct 2006 15:35:56 +0300 Message-ID: <20061012123556.GA89997@gothmog.pc> References: <549c434ebfb50d1a4ca2.1160608974@gothmog.pc> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1160656610 31241 80.91.229.2 (12 Oct 2006 12:36:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2006 12:36:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 14:36:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GXznb-0000Ar-Ev for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 14:36:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXzna-0002Q4-TS for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 08:36:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GXzn3-0002L5-3z for emacs-devel@gnu.org; Thu, 12 Oct 2006 08:35:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GXzn1-0002Ke-KS for emacs-devel@gnu.org; Thu, 12 Oct 2006 08:35:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXzn1-0002KU-9w for emacs-devel@gnu.org; Thu, 12 Oct 2006 08:35:55 -0400 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GXzvE-0005gn-NX for emacs-devel@gnu.org; Thu, 12 Oct 2006 08:44:25 -0400 Original-Received: from gothmog.pc (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id k9CCZLmR005372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 12 Oct 2006 15:35:24 +0300 Original-Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.8/8.13.8) with ESMTP id k9CCZwu8090538; Thu, 12 Oct 2006 15:35:58 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from giorgos@localhost) by gothmog.pc (8.13.8/8.13.8/Submit) id k9CCZu4r090537; Thu, 12 Oct 2006 15:35:56 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-To: Kenichi Handa Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.593, required 5, AWL -0.20, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60656 Archived-At: On 2006-10-12 14:59, Kenichi Handa wrote: > In article <549c434ebfb50d1a4ca2.1160608974@gothmog.pc>, > Giorgos Keramidas writes: > > > The current `make install' target of the leim/ subdirectory has a subtle > > problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all. > > Oops, my last change was not sufficient. > > > The following patch fixes this. > > It seems that the patch removes CVS and etc. from the current > directory if it equals to INSTALLDIR. Yes, the first version of the patch I send was buggy in this way. Sorry for not having tested it as thoroughly. > So, I've just installed the different fix. Could you please try it? I just pulled the changes from CVS. It seems to include this part: + if [ ! -d ${INSTALLDIR} ] ; then \ + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \ + else true; fi We don't really *need* to have an else branch in all statements. We can write this as: + if [ ! -d ${INSTALLDIR} ] ; then \ + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \ + fi Apart from this minor difference, this is identical to the second version of the same patch I posted, so I'm fairly confident it works. I will test it with a new build later today though. Thank you for the ultra fast responses :)