From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Slawomir Nowaczyk Newsgroups: gmane.emacs.devel Subject: Following links in *Help* do not add files to file-name-history Date: Thu, 12 Oct 2006 12:33:53 +0200 Message-ID: <20061012115933.C387.SLAWOMIR.NOWACZYK.847@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1160649326 1349 80.91.229.2 (12 Oct 2006 10:35:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2006 10:35:26 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 12:35:24 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GXxtb-0001AV-GY for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 12:34:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXxta-0001wf-Uf for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 06:34:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GXxt9-0001t9-01 for emacs-devel@gnu.org; Thu, 12 Oct 2006 06:34:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GXxt5-0001lh-QX for emacs-devel@gnu.org; Thu, 12 Oct 2006 06:34:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXxt5-0001lR-IG for emacs-devel@gnu.org; Thu, 12 Oct 2006 06:34:03 -0400 Original-Received: from [130.235.16.11] (helo=himmelsborg.cs.lth.se) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GXy1I-0008Al-0j for emacs-devel@gnu.org; Thu, 12 Oct 2006 06:42:32 -0400 Original-Received: from [127.0.0.1] (slawek@dain [130.235.16.76]) by himmelsborg.cs.lth.se (8.13.6/8.13.6/perf-jw-tr) with ESMTP id k9CAY1rq013948 for ; Thu, 12 Oct 2006 12:34:01 +0200 (CEST) Original-To: emacs-devel@gnu.org X-Esmandil_Citation: done X-Mailer-Plugin: Popup Memopad for Becky!2 Ver.0.02 Rev.2 X-Mailer: Becky! ver. 2.25.02 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60641 Archived-At: Hello, Following link to source file in *Help* buffers (like C-h f lambda TAB RET) visits the file correctly, but does not add visited file to the file-name-history. I think it should. The following patch seems to work for me: ******************************************************************************** --- EmacsCVS/lisp/help-mode.el 2006-08-11 12:45:35.727585600 +0200 +++ Emacs/lisp/help-mode.el 2006-10-12 12:31:13.512827200 +0200 @@ -157,6 +157,7 @@ (let ((location (find-function-search-for-symbol fun nil file))) (pop-to-buffer (car location)) + (add-to-history 'file-name-history (buffer-file-name (car location))) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file")))) @@ -169,6 +170,7 @@ (setq file (help-C-file-name var 'var))) (let ((location (find-variable-noselect var file))) (pop-to-buffer (car location)) + (add-to-history 'file-name-history (buffer-file-name (car location))) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file")))) @@ -183,6 +185,7 @@ (let ((location (find-function-search-for-symbol fun 'defface file))) (pop-to-buffer (car location)) + (add-to-history 'file-name-history (buffer-file-name (car location))) (if (cdr location) (goto-char (cdr location)) (message "Unable to find location in file")))) ******************************************************************************** -- Best wishes, Slawomir Nowaczyk ( slawomir.nowaczyk.847@student.lu.se ) There are 3 kinds of people: those who can count & those who can't.