From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: rcirc bug Date: Tue, 5 Sep 2006 23:37:20 +0200 (CEST) Message-ID: <20060905213720.A150744004@Psilocybe.Update.UU.SE> References: <20060904135111.7ADB544005@Psilocybe.Update.UU.SE> <87mz9eknqm.fsf@cut.bc.hsia.telus.net> Reply-To: ams@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1157492380 4801 80.91.229.2 (5 Sep 2006 21:39:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 5 Sep 2006 21:39:40 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 05 23:39:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GKidp-0004zp-4g for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2006 23:39:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GKido-000577-LG for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2006 17:39:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GKida-000527-0T for emacs-devel@gnu.org; Tue, 05 Sep 2006 17:39:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GKidY-0004z8-II for emacs-devel@gnu.org; Tue, 05 Sep 2006 17:39:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GKidY-0004z0-Fb for emacs-devel@gnu.org; Tue, 05 Sep 2006 17:39:16 -0400 Original-Received: from [130.238.164.5] (helo=elvira.its.uu.se) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GKidY-0006md-NF for emacs-devel@gnu.org; Tue, 05 Sep 2006 17:39:16 -0400 Original-Received: by elvira.its.uu.se (Postfix, from userid 204) id 11230322; Tue, 5 Sep 2006 23:37:27 +0200 (MSZ) Original-Received: from elvira.its.uu.se(127.0.0.1) by elvira.its.uu.se via virus-scan id s274347; Tue, 5 Sep 06 23:37:20 +0200 Original-Received: from Psilocybe.Update.UU.SE (Psilocybe.Update.UU.SE [130.238.19.25]) by elvira.its.uu.se (Postfix) with ESMTP id B14C8322; Tue, 5 Sep 2006 23:37:20 +0200 (MSZ) Original-Received: by Psilocybe.Update.UU.SE (Postfix, from userid 30270) id A150744004; Tue, 5 Sep 2006 23:37:20 +0200 (CEST) Original-To: Ryan Yeske In-reply-to: <87mz9eknqm.fsf@cut.bc.hsia.telus.net> (message from Ryan Yeske on Tue, 05 Sep 2006 14:27:45 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59397 Archived-At: > rcirc tries to use member* without (require 'cl), which causes > breakage. The following patch fixes this: I don't think it will fix the problem in full; pushnew is also a 'cl macro. Maybe just changing pushnew to add-to-list would work? I don't know if there are more 'cl-isms in rcirc... (defun rcirc-record-activity (buffer &optional type) "Record BUFFER activity with TYPE." (with-current-buffer buffer (when (not (get-buffer-window (current-buffer) t)) (setq rcirc-activity (sort (add-to-list 'rcirc-activity (current-buffer)) (lambda (b1 b2) (let ((t1 (with-current-buffer b1 rcirc-last-post-time)) (t2 (with-current-buffer b2 rcirc-last-post-time))) (time-less-p t2 t1))))) (pushnew type rcirc-activity-types) (rcirc-update-activity-string))) (run-hook-with-args 'rcirc-activity-hooks buffer))