From: "Alfred M. Szmidt" <ams@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: rcirc bug
Date: Tue, 5 Sep 2006 23:37:20 +0200 (CEST) [thread overview]
Message-ID: <20060905213720.A150744004@Psilocybe.Update.UU.SE> (raw)
In-Reply-To: <87mz9eknqm.fsf@cut.bc.hsia.telus.net> (message from Ryan Yeske on Tue, 05 Sep 2006 14:27:45 -0700)
> rcirc tries to use member* without (require 'cl), which causes
> breakage.
The following patch fixes this:
I don't think it will fix the problem in full; pushnew is also a 'cl
macro. Maybe just changing pushnew to add-to-list would work? I
don't know if there are more 'cl-isms in rcirc...
(defun rcirc-record-activity (buffer &optional type)
"Record BUFFER activity with TYPE."
(with-current-buffer buffer
(when (not (get-buffer-window (current-buffer) t))
(setq rcirc-activity
(sort (add-to-list 'rcirc-activity (current-buffer))
(lambda (b1 b2)
(let ((t1 (with-current-buffer b1 rcirc-last-post-time))
(t2 (with-current-buffer b2 rcirc-last-post-time)))
(time-less-p t2 t1)))))
(pushnew type rcirc-activity-types)
(rcirc-update-activity-string)))
(run-hook-with-args 'rcirc-activity-hooks buffer))
next prev parent reply other threads:[~2006-09-05 21:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 13:51 rcirc bug Alfred M. Szmidt
2006-09-05 9:42 ` Richard Stallman
2006-09-05 21:27 ` Ryan Yeske
2006-09-05 21:37 ` Alfred M. Szmidt [this message]
2006-09-05 21:44 ` Ryan Yeske
2006-09-06 19:06 ` Richard Stallman
2006-09-06 19:13 ` Ryan Yeske
2006-09-07 23:19 ` Ryan Yeske
2006-09-08 15:11 ` Richard Stallman
2006-09-08 15:30 ` Drew Adams
2006-09-11 2:57 ` Chong Yidong
2006-09-11 15:17 ` Stuart D. Herring
2006-09-11 19:57 ` Richard Stallman
2006-09-05 21:44 ` Magnus Henoch
2006-09-07 20:59 ` Chong Yidong
2006-09-07 21:11 ` Stefan Monnier
2006-09-05 21:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060905213720.A150744004@Psilocybe.Update.UU.SE \
--to=ams@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).