unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
Cc: bug-cc-mode@gnu.org, emacs-devel@gnu.org
Subject: Re: FW: Font-lock misfontifies foo::bar in C++
Date: Sun, 6 Aug 2006 19:08:18 +0100	[thread overview]
Message-ID: <20060806180818.GC1245@muc.de> (raw)
In-Reply-To: <81CCA6588E60BB42BE68BD029ED4826008C0BB56@wimex2.wim.midas-kapiti.com>

Hi, Simon!

On Tue, Jul 25, 2006 at 09:48:45AM +0100, Marshall, Simon wrote:
> > > src/emacs -Q foo.cpp

> > > In the foo.cpp buffer, insert the text:

> > > void foo::bar()	 // wrong - foo in font-lock-constant-face
> (otherwise ok)

[ .... ]

> Hi Alan, why is c-reference-face-name used for foo in this context?  It
> cannot be a reference, it is a type name.

I emailed Martin Stjernholm, the author of the CC Mode font locking code,
and asked him about this.  Here is his answer:

#########################################################################

[ACM]:
> Martin, can you shed any light upon why "foo" in "foo::bar" is given
> c-reference-face-name?

Sure. "foo" doesn't get the type face since it isn't used as a type -
it's used as an identifier qualifier. Note that "foo" in a "foo::bar"
expression can be a namespace name too, which isn't a type at all.

So, put another way: The face is not chosen from what an identifier is
defined as but rather how it is used. Some examples:

Example 1:

    foo bar;

In this statement "foo" is used to specify the type of something.
Hence it gets the type face.

Example 2:

    ~foo();

This declares a destructor for the class foo. Here "foo" doesn't
specify the type of anything; it's only used in a special construct to
serve as the name of the destructor function. It therefore gets
font-lock-function-name-face.

Example 3:

    foo::bar

"foo" doesn't specify the type of anything here either. Its use is to
tell in which scope "bar" is declared. Hence it gets a face that is
different from the type face. I call this use "identifier qualifier".

To make this more obvious/precise, you could perhaps introduce another
face name variable, say c-qualifier-face-name, and make a suitable
mapping of it onto one of the existing font-lock faces. I don't think
it should be mapped to the type face though, because it would be used
for namespace names too. In lack of better alternatives I chose to map
it as I did.

(Btw, there's not necessarily a hard distinction between types and
constants in all languages. Again, it's (afaik) Pike that pushes the
limits in this regard. There a type name is nothing more than a class
that has been assigned to a constant.)
#########################################################################

[ .... ]

> Simon.

-- 
Alan.

  reply	other threads:[~2006-08-06 18:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-25  8:48 FW: Font-lock misfontifies foo::bar in C++ Marshall, Simon
2006-08-06 18:08 ` Alan Mackenzie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-16 14:35 Marshall, Simon
2006-08-07  8:32 Marshall, Simon
2006-08-16 11:47 ` Alan Mackenzie
     [not found] <81CCA6588E60BB42BE68BD029ED48260089A94BF@wimex2.wim.midas-kapiti.com>
2006-07-24 18:27 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060806180818.GC1245@muc.de \
    --to=acm@muc.de \
    --cc=bug-cc-mode@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).