Problem report #87

Problem report #87

[Dan Nicolaescu]

We have 4 new problem reports due to changes in the past 2
weeks. 


This one be no problem, after "realize_basic_faces (f)"
default_face = FACE_FROM_ID (f, DEFAULT_FACE_ID) should be non-null. 
Can someone double check this please?



CID: 87
Checker: FORWARD_NULL (help)
File: base/src/emacs/src/xfaces.c
Function: lookup_named_face
Description: Variable "&(default_face)->lface" tracked as NULL was
passed to a function that dereferences it.


5716 	int
5717 	lookup_named_face (f, symbol, c, signal_p)
5718 	     struct frame *f;
5719 	     Lisp_Object symbol;
5720 	     int c;
5721 	     int signal_p;
5722 	{
5723 	  Lisp_Object attrs[LFACE_VECTOR_SIZE];
5724 	  Lisp_Object symbol_attrs[LFACE_VECTOR_SIZE];
5725 	  struct face *default_face = FACE_FROM_ID (f, DEFAULT_FACE_ID);
5726 	

Event var_compare_op: Added "default_face" due to comparison "default_face == 0"
Also see events: [var_deref_model]
At conditional (1): "default_face == 0" taking true path

5727 	  if (default_face == NULL)
5728 	    {

At conditional (2): "realize_basic_faces == 0" taking false path

5729 	      if (!realize_basic_faces (f))
5730 		return -1;

At conditional (3): "0 < ((f)->face_cache)->used" taking false path

5731 	      default_face = FACE_FROM_ID (f, DEFAULT_FACE_ID);
5732 	    }
5733 	

At conditional (4): "get_lface_attributes == 0" taking false path

5734 	  if (!get_lface_attributes (f, symbol, symbol_attrs, signal_p))
5735 	    return -1;
5736 	

Event var_deref_model: Variable "&(default_face)->lface" tracked as NULL was passed to a function that dereferences it.
Also see events: [var_compare_op]

5737 	  bcopy (default_face->lface, attrs, sizeof attrs);
5738 	  merge_face_vectors (f, symbol_attrs, attrs, 0);
5739 	
5740 	  return lookup_face (f, attrs, c, NULL);
5741 	}