emacs-unicode-2 branch does not compile on 64 bit here

emacs-unicode-2 branch does not compile on 64 bit here

[Martin Ellis]

Hi,

[Sent here from #emacs - please CC me on any replies]

After configuring with:

 ./configure --prefix=/home/martin/emacs --with-freetype --with-xft --enable-font-backend --with-gtk

I was getting the following error building emacs-unicode-2 on AMD64, although the same code
compiled fine on a 32 bit machine:

martin@earthworm:~/emacs/emacs/src$ gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_GTK 
     -I. -I/home/martin/emacs/emacs/src -D_BSD_SOURCE -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
     -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
     -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/alsa -g -O2 -Wno-pointer-sign  font.c
font.c:2671: error: conflicting types for ‘Flist_fonts’
font.c:2523: error: previous implicit declaration of ‘Flist_fonts’ was here
font.c: In function ‘Ffont_fill_gstring’:
font.c:2947: warning: comparison is always false due to limited range of data type
font.c:2973: warning: comparison is always false due to limited range of data type
font.c: In function ‘Fget_font_glyphs’:
font.c:3076: warning: comparison is always true due to limited range of data type



After adding a function prototype it builds and appears to run fine:

Index: font.c
===================================================================
RCS file: /sources/emacs/emacs/src/Attic/font.c,v
retrieving revision 1.1.2.10
diff -u -r1.1.2.10 font.c
--- font.c      21 Jun 2006 01:24:36 -0000      1.1.2.10
+++ font.c      24 Jun 2006 23:40:19 -0000
@@ -2477,6 +2477,7 @@
   face->extra = NULL;
 }

+Lisp_Object Flist_fonts (Lisp_Object spec, Lisp_Object frame, Lisp_Object number, Lisp_Object prefer);
 Lisp_Object
 font_open_by_name (f, name)
      FRAME_PTR f;


Cheers
Martin

Re: emacs-unicode-2 branch does not compile on 64 bit here

[Richard Stallman]

    font.c:2671: error: conflicting types for ?Flist_fonts?
    font.c:2523: error: previous implicit declaration of ?Flist_fonts? was here
    font.c: In function ?Ffont_fill_gstring?:

Please investigate what the two conflicting types are.
That is the first step towards fixing the bug.

Re: emacs-unicode-2 branch does not compile on 64 bit here

[Kenichi Handa]

In article <200606250113.44329.martin.ellis@kdemail.net>, Martin Ellis <martin.ellis@kdemail.net> writes:

> After configuring with:

>  ./configure --prefix=/home/martin/emacs --with-freetype --with-xft --enable-font-backend --with-gtk

> I was getting the following error building emacs-unicode-2 on AMD64, although the same code
> compiled fine on a 32 bit machine:

> martin@earthworm:~/emacs/emacs/src$ gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_GTK 
>      -I. -I/home/martin/emacs/emacs/src -D_BSD_SOURCE -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
>      -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
>      -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/alsa -g -O2 -Wno-pointer-sign  font.c
> font.c:2671: error: conflicting types for ‘Flist_fonts’
> font.c:2523: error: previous implicit declaration of ‘Flist_fonts’ was here
> font.c: In function ‘Ffont_fill_gstring’:
> font.c:2947: warning: comparison is always false due to limited range of data type
> font.c:2973: warning: comparison is always false due to limited range of data type
> font.c: In function ‘Fget_font_glyphs’:
> font.c:3076: warning: comparison is always true due to limited range of data type

> After adding a function prototype it builds and appears to run fine:

Thank you for the report.   I've just installed this change
to fix the error at line 2671.

Index: font.h
===================================================================
RCS file: /cvsroot/emacs/emacs/src/Attic/font.h,v
retrieving revision 1.1.2.6
retrieving revision 1.1.2.7
diff -u -r1.1.2.6 -r1.1.2.7
--- font.h	19 Jun 2006 12:44:41 -0000	1.1.2.6
+++ font.h	26 Jun 2006 04:27:21 -0000	1.1.2.7
@@ -424,6 +424,7 @@
 extern int enable_font_backend;
 
 EXFUN (Ffont_spec, MANY);
+EXFUN (Flist_fonts, 4);
 
 extern Lisp_Object font_symbolic_weight P_ ((Lisp_Object font));
 extern Lisp_Object font_symbolic_slant P_ ((Lisp_Object font));

Could you please try again?  And, I'll install fixes for the
other warnings soon.

---
Kenichi Handa
handa@m17n.org