* Problem report #
@ 2006-04-30 16:40 Dan Nicolaescu
2006-04-30 17:58 ` Henrik Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2006-04-30 16:40 UTC (permalink / raw
CID: 2
Checker: DEADCODE (help)
File: emacs/lib-src/ebrowse.c
Function: member
Description: Assigning "1" to "type_seen"
2769 MATCH ();
2770 anonymous = 1;
2771
2772 /* More than one ident here to allow for MS-DOS specialties
2773 like `_export class' etc. The last IDENT seen counts
2774 as the class name. */
2775 while (!LOOKING_AT4 (YYEOF, ';', ':', '{'))
2776 {
2777 if (LOOKING_AT (IDENT))
2778 anonymous = 0;
2779 MATCH ();
2780 }
2781
2782 if (LOOKING_AT2 (':', '{'))
2783 class_definition (anonymous ? NULL : cls, class_tag, flags, 1);
2784 else
2785 skip_to (';');
2786 break;
2787
2788 case INT: case CHAR: case LONG: case UNSIGNED:
2789 case SIGNED: case CONST: case DOUBLE: case VOID:
2790 case SHORT: case VOLATILE: case BOOL: case WCHAR:
2791 case TYPENAME:
2792 typeseen:
Event const: After this line, the value of "type_seen" is equal to 1
Event assignment: Assigning "1" to "type_seen"
Also see events: [dead_error_line][dead_error_condition][assignment]
2793 type_seen = 1;
2794 MATCH ();
2795 break;
2796 }
2797 }
2798
2799 if (LOOKING_AT (';'))
2800 {
2801 /* The end of a member variable, a friend declaration or an access
2802 declaration. We don't want to add friend classes as members. */
2803 if (id && sc != SC_FRIEND && cls)
2804 {
2805 regexp = matching_regexp ();
2806 pos = BUFFER_POS ();
2807
2808 if (cls != NULL)
2809 {
Event dead_error_line: Cannot reach this line of code
Event dead_error_condition: On this path, the condition "type_seen != 0" could not be false
Also see events: [dead_error_condition][const][assignment]
2810 if (type_seen || !paren_seen)
2811 add_member_decl (cls, id, regexp, pos, 0, 1, sc, vis, 0);
2812 else
2813 add_member_decl (cls, id, regexp, pos, hash, 0, sc, vis, 0);
2814 }
2815 }
2816
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem report #
2006-04-30 16:40 Problem report # Dan Nicolaescu
@ 2006-04-30 17:58 ` Henrik Enberg
2006-05-01 4:20 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Henrik Enberg @ 2006-04-30 17:58 UTC (permalink / raw
Cc: emacs-devel
Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> CID: 2
> Checker: DEADCODE (help)
> File: emacs/lib-src/ebrowse.c
> Function: member
> Description: Assigning "1" to "type_seen"
[...]
> 2788 case INT: case CHAR: case LONG: case UNSIGNED:
> 2789 case SIGNED: case CONST: case DOUBLE: case VOID:
> 2790 case SHORT: case VOLATILE: case BOOL: case WCHAR:
> 2791 case TYPENAME:
> 2792 typeseen:
>
> Event const: After this line, the value of "type_seen" is equal to 1
> Event assignment: Assigning "1" to "type_seen"
> Also see events: [dead_error_line][dead_error_condition][assignment]
Uhm, as far as I can tell, type_seen may very well be 0 after this.
There are several cases where the code won't goto the typeseen label.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem report #
2006-04-30 17:58 ` Henrik Enberg
@ 2006-05-01 4:20 ` Richard Stallman
0 siblings, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2006-05-01 4:20 UTC (permalink / raw
Cc: dann, emacs-devel
> Event const: After this line, the value of "type_seen" is equal to 1
> Event assignment: Assigning "1" to "type_seen"
> Also see events: [dead_error_line][dead_error_condition][assignment]
Uhm, as far as I can tell, type_seen may very well be 0 after this.
There are several cases where the code won't goto the typeseen label.
I agree. I think the report is a confusion.
Dan, please mark this as not a real bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-01 4:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-30 16:40 Problem report # Dan Nicolaescu
2006-04-30 17:58 ` Henrik Enberg
2006-05-01 4:20 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).