From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: use faces on the mode-line for compile.el Date: Wed, 19 Apr 2006 23:20:11 -0700 Message-ID: <200604200620.k3K6KB7T019392@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145514067 18157 80.91.229.2 (20 Apr 2006 06:21:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Apr 2006 06:21:07 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 20 08:21:06 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FWSXI-0007Ni-JH for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2006 08:21:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWSXH-0004Kn-VI for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2006 02:21:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FWSX6-0004Ki-KV for emacs-devel@gnu.org; Thu, 20 Apr 2006 02:20:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FWSX4-0004KW-SS for emacs-devel@gnu.org; Thu, 20 Apr 2006 02:20:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWSX4-0004KT-PT for emacs-devel@gnu.org; Thu, 20 Apr 2006 02:20:50 -0400 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FWSYL-0001a0-EA for emacs-devel@gnu.org; Thu, 20 Apr 2006 02:22:09 -0400 Original-Received: from vino.ics.uci.edu (vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.13.6/8.13.5) with ESMTP id k3K6KB7T019392 for ; Wed, 19 Apr 2006 23:20:11 -0700 (PDT) Original-To: emacs-devel@gnu.org Original-Lines: 73 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_72 0.60) X-ICS-MailScanner-From: dann@vino.ics.uci.edu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53120 Archived-At: If the mode-line for the compilation buffer would be a bit more visible it would be easier to see if a compilation is still running (which is handy if you have compilations that take a long time and don't want to spend too much time checking if it's done). Also if the compilation fails it's nice to be able to see it faster. A simple patch can accomplish the above. It uses font-lock-warning-face which is designed to be highly visible. IMO this is a very nice feature to have, and simple to implement... Thoughts? *** compile.el 04 Apr 2006 09:50:37 -0700 1.394 --- compile.el 19 Apr 2006 22:54:58 -0700 *************** *** 1060,1066 **** (start-process-shell-command (downcase mode-name) outbuf command)))) ;; Make the buffer's mode line show process state. ! (setq mode-line-process '(":%s")) (set-process-sentinel proc 'compilation-sentinel) (set-process-filter proc 'compilation-filter) (set-marker (process-mark proc) (point) outbuf) --- 1060,1066 ---- (start-process-shell-command (downcase mode-name) outbuf command)))) ;; Make the buffer's mode line show process state. ! (setq mode-line-process (list (propertize ":%s" 'face 'font-lock-warning-face))) (set-process-sentinel proc 'compilation-sentinel) (set-process-filter proc 'compilation-filter) (set-marker (process-mark proc) (point) outbuf) *************** *** 1074,1080 **** ;; No asynchronous processes available. (message "Executing `%s'..." command) ;; Fake modeline display as if `start-process' were run. ! (setq mode-line-process ":run") (force-mode-line-update) (sit-for 0) ; Force redisplay (let* ((buffer-read-only nil) ; call-process needs to modify outbuf --- 1074,1080 ---- ;; No asynchronous processes available. (message "Executing `%s'..." command) ;; Fake modeline display as if `start-process' were run. ! (setq mode-line-process (propertize ":run" 'face 'font-lock-warning-face)) (force-mode-line-update) (sit-for 0) ; Force redisplay (let* ((buffer-read-only nil) ; call-process needs to modify outbuf *************** *** 1403,1409 **** ;; Prevent that message from being recognized as a compilation error. (add-text-properties omax (point) (append '(compilation-handle-exit t) nil)) ! (setq mode-line-process (format ":%s [%s]" process-status (cdr status))) ;; Force mode line redisplay soon. (force-mode-line-update) (if (and opoint (< opoint omax)) --- 1403,1415 ---- ;; Prevent that message from being recognized as a compilation error. (add-text-properties omax (point) (append '(compilation-handle-exit t) nil)) ! (setq mode-line-process ! (concat (format ":%s " process-status) ! (format (if (> exit-status 0) ! (propertize "[%s]" 'face 'font-lock-warning-face) ! "[%s]") ! (cdr status)))) ! (message (format "exit status: %s %s" exit-status (> 0 exit-status))) ;; Force mode line redisplay soon. (force-mode-line-update) (if (and opoint (< opoint omax))