From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Fkill_emacs NO_RETURN Date: Mon, 10 Apr 2006 12:27:52 -0700 Message-ID: <200604101927.k3AJRq1O007269@scanner2.ics.uci.edu> References: <200604100640.k3A6ewE9011199@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144697353 30518 80.91.229.2 (10 Apr 2006 19:29:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Apr 2006 19:29:13 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 10 21:29:11 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FT24Q-0006Er-5J for ged-emacs-devel@m.gmane.org; Mon, 10 Apr 2006 21:29:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT24P-0005oj-J0 for ged-emacs-devel@m.gmane.org; Mon, 10 Apr 2006 15:29:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FT24B-0005nI-Mb for emacs-devel@gnu.org; Mon, 10 Apr 2006 15:28:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FT24A-0005mt-U4 for emacs-devel@gnu.org; Mon, 10 Apr 2006 15:28:51 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT24A-0005mh-K7 for emacs-devel@gnu.org; Mon, 10 Apr 2006 15:28:50 -0400 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FT28q-0000cm-Ou; Mon, 10 Apr 2006 15:33:41 -0400 Original-Received: from vino.ics.uci.edu (vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.13.6/8.13.5) with ESMTP id k3AJRq1O007269; Mon, 10 Apr 2006 12:27:52 -0700 (PDT) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Mon, 10 Apr 2006 14:25:45 -0400") Original-Lines: 31 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@vino.ics.uci.edu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52614 Archived-At: Richard Stallman writes: > I deleted the NO_RETURN for Fkill_emacs to avoid hassles. > > Marking functions NO_RETURN is desirable from a few points of view: > -it helps gcc do a better job for the -Wuninitialized warning > > Surely Fkill_emacs makes no difference to this. > > -it helps lint type tools, it will avoid analyzing the same code over > and over when a new tool warns about it only to discover there's no > problem. > > Not terribly important. > > -it helps code generation: for example by just marking > `wrong_type_argument' as NO_RETURN the text size decreases from > 1483168 bytes to 1474080 bytes (ie ~9KB) on my x86 system using > gcc-4.1 > > That may be significant for wrong_type_argument, but not for Fkill_emacs. > > Perhaps it is worth adding the NO_RETURN for wrong_type_argument. > It is called a lot more than Fkill_emacs. The reason I referred to wrong_type_argument is that it has the same issue as Fkill_emacs: it has a return statement, so marking it as NO_RETURN would mean having to do something about the return statement. So please make a decision about marking wrong_type_argument and/or Fkill_emacs as NO_RETURN.