From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: locate-with-filter Date: Sun, 19 Mar 2006 23:12:15 -0600 (CST) Message-ID: <200603200512.k2K5CFN12390@raven.dms.auburn.edu> References: <200603160048.k2G0msu23696@raven.dms.auburn.edu> <200603170221.k2H2L1H14401@raven.dms.auburn.edu> <17435.52238.927514.585806@kahikatea.snap.net.nz> <200603181716.k2IHGpN17847@raven.dms.auburn.edu> <17436.56026.490667.58771@kahikatea.snap.net.nz> <200603190455.k2J4tEK25830@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1142831897 21101 80.91.229.2 (20 Mar 2006 05:18:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Mar 2006 05:18:17 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 20 06:18:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FLCmT-0003Ca-GM for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2006 06:18:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLCmS-0003it-Nw for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2006 00:18:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FLCm9-0003ij-Bh for emacs-devel@gnu.org; Mon, 20 Mar 2006 00:17:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FLCm7-0003iQ-Db for emacs-devel@gnu.org; Mon, 20 Mar 2006 00:17:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLCm7-0003iN-6k for emacs-devel@gnu.org; Mon, 20 Mar 2006 00:17:51 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1FLCrX-0002dv-S8; Mon, 20 Mar 2006 00:23:28 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.13.4+Sun/8.13.3) with ESMTP id k2K5HkYK006889; Sun, 19 Mar 2006 23:17:46 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id k2K5CFN12390; Sun, 19 Mar 2006 23:12:15 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Sun, 19 Mar 2006 16:51:07 -0500) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.1 (manatee.dms.auburn.edu [131.204.53.104]); Sun, 19 Mar 2006 23:17:46 -0600 (CST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51868 Archived-At: Richard Stallman wrote: Would you please install the corrected version of my patch, and your new function help-follow-symbol for C-c C-c? Please also document C-c C-c in Help Mode in help.texi. It is currently not documented. Done. I also updated lispref/tips.texi. While grepping, I noticed problems with `list-faces-display' and `list-character-sets'. These say: "Use or M-x help-follow" in their introductory text, even though `M-x help-follow' is bound to RET in these buffers. I am not sure, but this could be due to `minor-mode-overriding-map-alist'. This is even worse than it appears, because with the latest version of `help-follow', `M-x help-follow' does not even follow references. It just incorrectly messages "No cross-reference here" _everywhere_. With the latest version of `help-follow', rebinding help-follow to something different from RET does not work anymore, so we might as well hard code RET in the doc. It might actually be good to make `M-x help-follow' work correctly on references again, by restoring part of the old `help-follow-mouse' and `help-follow' code. This would allow binding them to other keys than mouse-{1,2} or RET. The patch to help-mode.el below does that. It entirely keeps the new behavior. The only difference is that `M-x help-follow' would once again work on cross references and that it could be rebound. I believe that it would not solve the above problems with `list-faces-display' and `list-character-sets' so I suggest to just hard code RET in those docs. The patches below do this. I can install if desired. ===File ~/help-mode-diff==================================== *** help-mode.el 19 Mar 2006 17:03:47 -0600 1.44 --- help-mode.el 19 Mar 2006 21:45:44 -0600 *************** *** 619,636 **** (apply function args))) ;; The doc string is meant to explain what buttons do. ! (defun help-follow-mouse () ! "Follow the cross-reference that you click on." ! (interactive) ! (error "No cross-reference here")) ;; The doc string is meant to explain what buttons do. ! (defun help-follow () ! "Follow cross-reference at point. For the cross-reference format, see `help-make-xrefs'." ! (interactive) ! (error "No cross-reference here")) (defun help-follow-symbol (&optional pos) "In help buffer, show docs for symbol at POS, defaulting to point. --- 619,643 ---- (apply function args))) ;; The doc string is meant to explain what buttons do. ! (defun help-follow-mouse (click) ! "Follow the cross-reference that you CLICK on." ! (interactive "e") ! (let* ((start (event-start click)) ! (window (car start)) ! (pos (car (cdr start)))) ! (with-current-buffer (window-buffer window) ! (help-follow pos)))) ;; The doc string is meant to explain what buttons do. ! (defun help-follow (&optional pos) ! "Follow cross-reference at POS, defaulting to point. For the cross-reference format, see `help-make-xrefs'." ! (interactive "d") ! (unless pos ! (setq pos (point))) ! (unless (push-button pos) ! (error "No cross-reference here"))) (defun help-follow-symbol (&optional pos) "In help buffer, show docs for symbol at POS, defaulting to point. ============================================================ ===File ~/faces-diff======================================== *** faces.el 06 Feb 2006 16:01:46 -0600 1.348 --- faces.el 19 Mar 2006 21:21:23 -0600 *************** *** 1205,1211 **** (concat "Use " (if (display-mouse-p) "\\[help-follow-mouse] or ") ! "\\[help-follow] on a face name to customize it\n" "or on its sample text for a description of the face.\n\n"))) (setq help-xref-stack nil) (dolist (face faces) --- 1205,1211 ---- (concat "Use " (if (display-mouse-p) "\\[help-follow-mouse] or ") ! "RET on a face name to customize it\n" "or on its sample text for a description of the face.\n\n"))) (setq help-xref-stack nil) (dolist (face faces) ============================================================ ===File ~/mule-dialog-diff================================== *** mule-diag.el 24 Sep 2005 09:35:46 -0500 1.98 --- mule-diag.el 19 Mar 2006 21:19:26 -0600 *************** *** 162,168 **** (substitute-command-keys (concat "Use " (if (display-mouse-p) "\\[help-follow-mouse] or ") ! "\\[help-follow]:\n"))) (insert " on a column title to sort by that title,") (indent-to 56) (insert "+----DIMENSION\n") --- 162,168 ---- (substitute-command-keys (concat "Use " (if (display-mouse-p) "\\[help-follow-mouse] or ") ! "RET:\n"))) (insert " on a column title to sort by that title,") (indent-to 56) (insert "+----DIMENSION\n") ============================================================