From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: locate-with-filter Date: Sat, 18 Mar 2006 19:28:40 -0600 (CST) Message-ID: <200603190128.k2J1Seg23585@raven.dms.auburn.edu> References: <200603160048.k2G0msu23696@raven.dms.auburn.edu> <200603170221.k2H2L1H14401@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1142732077 12323 80.91.229.2 (19 Mar 2006 01:34:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 19 Mar 2006 01:34:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 19 02:34:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FKmoS-0004l8-U2 for ged-emacs-devel@m.gmane.org; Sun, 19 Mar 2006 02:34:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FKmoS-0008T6-DG for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2006 20:34:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FKmoA-0008SR-Gz for emacs-devel@gnu.org; Sat, 18 Mar 2006 20:34:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FKmo9-0008Rz-0i for emacs-devel@gnu.org; Sat, 18 Mar 2006 20:34:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FKmo8-0008Rs-Gi for emacs-devel@gnu.org; Sat, 18 Mar 2006 20:34:12 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1FKmtI-0001Dt-Q7; Sat, 18 Mar 2006 20:39:33 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.13.4+Sun/8.13.3) with ESMTP id k2J1Y7JU002520; Sat, 18 Mar 2006 19:34:07 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id k2J1Seg23585; Sat, 18 Mar 2006 19:28:40 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Sat, 18 Mar 2006 03:44:03 -0500) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.1 (manatee.dms.auburn.edu [131.204.53.104]); Sat, 18 Mar 2006 19:34:07 -0600 (CST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51839 Archived-At: Richard Stallman wrote: I think we can effectively eliminate help-follow. It is not used for following any of the links that are explicitly presented in the doc string. So I propose this change: This looks good, except that there are three problems: 1. The most obvious problem is that your patch fails to erase part of the old help-follow. Hence, after applying your patch, help-mode.el does not compile. This is, of course, trivial to fix. 2. After your changes, the CLICK arg to help-follow-mouse and the POS arg to help-follow are unused and hence should be deleted. Then CLICK should no longer be capitalized in the docstring of `help-follow-mouse' and the doc of `help-follow' should no longer mention POS. I suggest: ;; The doc string is meant to explain what buttons do. (defun help-follow-mouse () "Follow the cross-reference that you click on." (interactive) (error "No cross-reference here")) ;; The doc string is meant to explain what buttons do. (defun help-follow () "Follow cross-reference at point. For the cross-reference format, see `help-make-xrefs'." (interactive) (error "No cross-reference here")) 3. help-follow is not only bound to RET and mouse-2, but also to `C-c C-c'. The `C-c C-c' binding is _not_ shadowed by xrefs. Hence, `C-c C-c' gives the error message "No cross-reference here", everywhere, including on xrefs. Hence, either the `C-c C-c' binding should be deletted, or, alternatively, the _old_ help-follow could be renamed to `help-follow-word' and `C-c C-c' could be bound to `help-follow-word' in help buffers. If we do the latter, people who like the feature can still use it and they can even rebind it to RET if they prefer the old behavior. Sincerely, Luc.