From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: make bootstrap: need moral support. :-( Date: Wed, 22 Feb 2006 12:54:22 +0200 Message-ID: <20060222105422.GA1981@flame.pc> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140682801 19844 80.91.229.2 (23 Feb 2006 08:20:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Feb 2006 08:20:01 +0000 (UTC) Cc: "Randal L. Schwartz" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 23 09:19:59 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FCBhc-0006xS-9G for ged-emacs-devel@m.gmane.org; Thu, 23 Feb 2006 09:19:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FCBPM-0004AE-AF for ged-emacs-devel@m.gmane.org; Thu, 23 Feb 2006 03:01:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FBrkJ-0007gn-Od for emacs-devel@gnu.org; Wed, 22 Feb 2006 06:01:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FBrfm-0005tN-1U for emacs-devel@gnu.org; Wed, 22 Feb 2006 05:57:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FBreQ-0005Vt-Bi for emacs-devel@gnu.org; Wed, 22 Feb 2006 05:55:19 -0500 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FBrkm-0004oA-Ik; Wed, 22 Feb 2006 06:01:53 -0500 Original-Received: from flame.pc (aris.bedc.ondsl.gr [62.103.39.226]) (authenticated bits=128) by igloo.linux.gr (8.13.5/8.13.5/Debian-3) with ESMTP id k1MAsnvI023192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 22 Feb 2006 12:54:53 +0200 Original-Received: from flame.pc (flame [127.0.0.1]) by flame.pc (8.13.4/8.13.4) with ESMTP id k1MAsRrf001986; Wed, 22 Feb 2006 12:54:27 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from keramida@localhost) by flame.pc (8.13.4/8.13.4/Submit) id k1MAsMZu001985; Wed, 22 Feb 2006 12:54:22 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-To: Francesco Potorti` Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.368, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.83, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50887 Archived-At: On 2006-02-22 11:30, Francesco Potorti` wrote: > >=================================================================== > >--- emacs/lib-src/etags.c (.../branches/gnu) (revision 26) > >+++ emacs/lib-src/etags.c (.../trunk) (revision 26) > >@@ -414,8 +414,8 @@ > > static void canonicalize_filename __P((char *)); > > static void linebuffer_init __P((linebuffer *)); > > static void linebuffer_setlen __P((linebuffer *, int)); > >-static PTR xmalloc __P((unsigned int)); > >-static PTR xrealloc __P((char *, unsigned int)); > >+PTR xmalloc __P((unsigned int)); > >+PTR xrealloc __P((char *, unsigned int)); > > > > > > static char searchar = '/'; /* use /.../ searches */ > >@@ -6864,7 +6864,7 @@ > > } > > > > /* Like malloc but get fatal error if memory is exhausted. */ > >-static PTR > >+PTR > > xmalloc (size) > > unsigned int size; > > { > >@@ -6874,7 +6874,7 @@ > > return result; > > } > > > >-static PTR > >+PTR > > xrealloc (ptr, size) > > char *ptr; > > unsigned int size; > >%%% > > This patch is harmless, from the etags point of view. The choice for > "static" was of theoretical cleanness and source documentation, but > involved no practical issues. > > If you need that patch, I can apply it myself (I am the etags > maintainer) or you can apply it, if you like it better. Just let me > know. No, that's fine. Thanks for the offer. The patch was only needed while regex.c used xmalloc/xrealloc. Now that the change is reverted, I've locally reverted this patch from my tree too. Again, thanks :)