* Other problem in Themes.
@ 2005-12-24 16:39 Luc Teirlinck
2005-12-24 17:37 ` Chong Yidong
2005-12-25 19:07 ` Richard M. Stallman
0 siblings, 2 replies; 3+ messages in thread
From: Luc Teirlinck @ 2005-12-24 16:39 UTC (permalink / raw)
(emacs)Custom Themes contains the sentence:
You can load the themes you've previously defined with the command
`load-theme'. It prompts for a theme name in the minibuffer, then
loads that theme if it isn't already loaded.
I believe that in an earlier discussion of Custom Themes (several
months ago), we decided that load-theme should _unconditionally_ load
themes, otherwise bugs resulted. I believe that this was why the name
of the command was changed from require-theme to load-theme. Either
the "if it isn't already loaded" part of the above quote is false,
or else the old bugs are probably still present (or reintroduced).
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Other problem in Themes.
2005-12-24 16:39 Other problem in Themes Luc Teirlinck
@ 2005-12-24 17:37 ` Chong Yidong
2005-12-25 19:07 ` Richard M. Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2005-12-24 17:37 UTC (permalink / raw)
Cc: emacs-devel
> You can load the themes you've previously defined with the command
> `load-theme'. It prompts for a theme name in the minibuffer, then
> loads that theme if it isn't already loaded.
>
> Either the "if it isn't already loaded" part of the above quote is
> false,
Yes, that was clearly a mistake. I fixed that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Other problem in Themes.
2005-12-24 16:39 Other problem in Themes Luc Teirlinck
2005-12-24 17:37 ` Chong Yidong
@ 2005-12-25 19:07 ` Richard M. Stallman
1 sibling, 0 replies; 3+ messages in thread
From: Richard M. Stallman @ 2005-12-25 19:07 UTC (permalink / raw)
Cc: emacs-devel
I believe that in an earlier discussion of Custom Themes (several
months ago), we decided that load-theme should _unconditionally_ load
themes, otherwise bugs resulted.
ISTR that that was meant to solve problems about order of priority
of settings in various themes. I solved those problems in
a different way, by writing custom-theme-recalc-variable etc.
As far as I know, there is no reason for this any more.
> Either the "if it isn't already loaded" part of the above quote is
> false,
Yes, that was clearly a mistake. I fixed that.
I think it was not a mistake. load-theme calls require,
and require doesn't load the file if it was already loaded.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-25 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-24 16:39 Other problem in Themes Luc Teirlinck
2005-12-24 17:37 ` Chong Yidong
2005-12-25 19:07 ` Richard M. Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).