From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.devel Subject: Re: flyspell.el [1.90->1.91] flyspell-large-region-beg should be moved after good match Date: Mon, 19 Dec 2005 01:41:15 +0100 Message-ID: <20051219004115.GA24197@agmartin.aq.upm.es> References: <20051216124235.GA3357@agmartin.aq.upm.es> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134953142 29440 80.91.229.2 (19 Dec 2005 00:45:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 19 Dec 2005 00:45:42 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 19 01:45:39 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Eo993-0005Kl-O7 for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2005 01:44:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eo982-0001Bz-94 for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2005 19:43:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Eo97f-000136-2E for emacs-devel@gnu.org; Sun, 18 Dec 2005 19:43:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Eo970-0000hP-B9 for emacs-devel@gnu.org; Sun, 18 Dec 2005 19:42:49 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eo96g-0000Sm-AH for emacs-devel@gnu.org; Sun, 18 Dec 2005 19:42:26 -0500 Original-Received: from [138.100.4.49] (helo=edison.ccupm.upm.es) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Eo99X-00022v-Dd for emacs-devel@gnu.org; Sun, 18 Dec 2005 19:45:23 -0500 Original-Received: from debian ([138.100.247.74]) by edison.ccupm.upm.es (8.12.10/8.12.10) with ESMTP id jBJ0fTQ2002556; Mon, 19 Dec 2005 01:41:29 +0100 Original-Received: by debian (Postfix, from userid 1000) id EBFC51803F; Mon, 19 Dec 2005 01:41:15 +0100 (CET) Original-To: emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48020 Archived-At: On Fri, Dec 16, 2005 at 08:03:25PM -0500, Richard M. Stallman wrote: > I think this fix is a cleaner one. Does it work right? > > *** flyspell.el 04 Dec 2005 12:42:38 -0500 1.91 > --- flyspell.el 16 Dec 2005 19:58:07 -0500 > *************** > *** 1311,1316 **** > --- 1311,1318 ---- > (ispell-otherchars (ispell-get-otherchars))) > (with-current-buffer flyspell-external-ispell-buffer > (goto-char (point-min)) > + (with-current-buffer flyspell-large-region-buffer > + (goto-char flyspell-large-region-beg)) > ;; Loop over incorrect words. > (while (re-search-forward "\\([^\n]+\\)\n" (point-max) t) > ;; Bind WORD to the next one. I have tested that change in Debian sarge emacs21.4 with the french Hydro Quebec ispell dict and the same french ispell dictionary (with the old boundary-chars mistmatches) and that seems to cause problems with forward jumps over regions. These problems are probably related to the boundary-chars mismatch, but since this can appear from user .emacs files in a rather obscure mode I would rather leave patch the other way. I will try testing this in a current emacs when I can. I still do not understand where and why is the jump produced in that file, but as mentioned above seems related to words tagged as not found because contain chars not in casechars or boundary-chars, but actually found in the search loop thus moving point. -- Agustin