unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: emacs-devel@gnu.org
Subject: Re: custom-save-variables: Unknown requested feature: nil
Date: Wed, 30 Nov 2005 19:55:46 -0600 (CST)	[thread overview]
Message-ID: <200512010155.jB11tkm26390@raven.dms.auburn.edu> (raw)
In-Reply-To: <091D7EC2-1681-4CA8-925B-4533F30F5A77@davids-welt.de> (message from David Reitter on Wed, 30 Nov 2005 20:09:27 +0000)

David Reitter wrote:

   I don't know what caused it. The below change makes the message go  
   away, but it's quite possibly not the right fix.

I believe that it is the right fix, but the same fix needs to be
applied to three other options, as I pointed out in my earlier reply.

   That `:require nil' came from the following change by Stefan Monnier
   on 2002-09-13:

	* simple.el: Provide `simple'.
	(transient-mark-mode, line-number-mode, column-number-mode):
	Pass an explicit `:require nil' argument.

   I do not know the reason for that change.

Whatever the reason for that change, it seems wrong.  I believe that
it tried to undo an at the time automatic :require written by
define-minor-mode.  It did not do that.  Instead it tried to require
the library nil.el _in addition_ to the other require, instead of
overwriting it.  (A defcustom can have more than one :require.  These
do not override each other.  Instead, all libraries are required by
the defcustom.)  This did not lead to an error, because of code in
custom-save-variables:

	    (when (and (symbolp request) (not (featurep request)))
	          (message "Unknown requested feature: %s" request)
		  (setq requests (delq request requests))))

which eliminated the `:require nil'.

If you disable the above piece of code and customize transient-mark-mode
and save it, then the next time you try to load your init file, it
will yield an error because it can not open the library nil.

Not only did the 2002 change not do what it tried to do, it is also no
longer necessary to try to do it, since the following more recent change:

2005-06-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	    * emacs-lisp/easy-mmode.el (define-minor-mode): Don't
	    automatically add a :require to the defcustom.

I believe that the `:require nil' should be deleted in the defcustoms
for transient-mark-mode, line-number-mode, column-number-mode and
size-indication-mode.

Sincerely,

Luc.

  parent reply	other threads:[~2005-12-01  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-30 20:09 custom-save-variables: Unknown requested feature: nil David Reitter
2005-11-30 20:25 ` Luc Teirlinck
2005-12-01  1:55 ` Luc Teirlinck [this message]
2005-12-01  2:05   ` Luc Teirlinck
2005-12-02  2:07   ` Richard M. Stallman
2005-12-02  3:38     ` Luc Teirlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200512010155.jB11tkm26390@raven.dms.auburn.edu \
    --to=teirllm@dms.auburn.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).