Re: Global Font Lock by default

[Dan Nicolaescu <dann@ics.uci.edu>]

Romain Francoise <romain@orebokech.com> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > > It seems that the difference is the fact that on 8 color ttys the face
  > > does not specify any properties.
  > 
  > Yes, but the reason why that makes a difference only when font-lock.el
  > is loaded in a dumped Emacs escapes me...

When dumping this part of the font-lock-comment-face face specification matches:
 (t (:weight bold :slant italic)) so the face is created with bold and
 italic properties.

later at run time face-spec-choose is called this will match: 
"((class color) (min-colors 8) (background light))"
but because it specifies no properties face-spec-set returns 
nil => face-spec-reset-face is not called in face-spec-set => the bold
and italic attributes are kept... 

Is this a corner case that was not exercised until now? Or is this by
design? 

In case this is by design, then a better "fix" would be this: 

*** font-lock.el	31 Oct 2005 08:29:09 -0800	1.280
--- font-lock.el	31 Oct 2005 14:06:07 -0800	
***************
*** 1691,1699 ****
      (((class color) (min-colors 16) (background dark))
       (:foreground "red1"))
      (((class color) (min-colors 8) (background light))
!      )
      (((class color) (min-colors 8) (background dark))
!      )
      (t (:weight bold :slant italic)))
    "Font Lock mode face used to highlight comments."
    :group 'font-lock-highlighting-faces)
--- 1691,1699 ----
      (((class color) (min-colors 16) (background dark))
       (:foreground "red1"))
      (((class color) (min-colors 8) (background light))
!      (:inherit default))
      (((class color) (min-colors 8) (background dark))
!      (:inherit default))
      (t (:weight bold :slant italic)))
    "Font Lock mode face used to highlight comments."
    :group 'font-lock-highlighting-faces)