unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Masatake YAMATO <jet@gyve.org>
Cc: emacs-devel@gnu.org
Subject: Re: Enhanced enhanced visual feedback in `*Completions*' buffer
Date: Sun, 09 Oct 2005 13:16:10 +0900 (JST)	[thread overview]
Message-ID: <20051009.131610.197346394.jet@gyve.org> (raw)
In-Reply-To: <E1EONbi-0000nZ-Vt@fencepost.gnu.org>

> The feature seems like a natural generalization of the existing
> feature, but
> 
>     I introduce a variable, `completion-common-string' which is used as a
>     hint in `completion-setup-function' to put faces to *Completions*
>     buffer. Client code like `lisp-complete-symbol' sets
>     `completion-common-string'.
> 
> is somewhat of a pain in the neck.  And it would need to be documented
> in NEWS and the Lisp manual.

Yes, it would need.

> Have you found all the functions in Emacs that would need to be changed?

Not yet. I may have to check all the place where `display-completion-list' 
is used.

> Is this variable the best API for it?  Would it be better
> to add an optional argument to display-completion-list?

What you wrote is much beter. 
I'll rewrite my patch.

Thank you for reviwing.
Masatake YAMATO

  reply	other threads:[~2005-10-09  4:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-08  7:02 Enhanced enhanced visual feedback in `*Completions*' buffer Masatake YAMATO
2005-10-08 22:55 ` Richard M. Stallman
2005-10-09  4:16   ` Masatake YAMATO [this message]
2005-10-09 19:12     ` Masatake YAMATO
2005-10-10  4:15     ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051009.131610.197346394.jet@gyve.org \
    --to=jet@gyve.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).