From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: obsolete comment in tool-bar.el Date: Thu, 14 Jul 2005 22:24:48 -0500 (CDT) Message-ID: <200507150324.j6F3OmC12530@raven.dms.auburn.edu> References: <200507071915.j67JFZT29961@raven.dms.auburn.edu> <200507090235.j692ZER04883@raven.dms.auburn.edu> <200507110321.j6B3LgG09526@raven.dms.auburn.edu> <85y88dfcqw.fsf@lola.goethe.zz> <200507130302.j6D32qE05640@raven.dms.auburn.edu> <200507140208.j6E28tr08794@raven.dms.auburn.edu> <200507142205.j6EM51f12059@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1121398042 4529 80.91.229.2 (15 Jul 2005 03:27:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Jul 2005 03:27:22 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 15 05:27:11 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DtGqp-0007IY-IK for ged-emacs-devel@m.gmane.org; Fri, 15 Jul 2005 05:26:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtGsa-0007Jh-Md for ged-emacs-devel@m.gmane.org; Thu, 14 Jul 2005 23:28:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DtGrQ-0006px-4i for emacs-devel@gnu.org; Thu, 14 Jul 2005 23:27:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DtGrO-0006pK-Tc for emacs-devel@gnu.org; Thu, 14 Jul 2005 23:27:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DtGrO-0006on-Jy for emacs-devel@gnu.org; Thu, 14 Jul 2005 23:27:34 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DtGx7-0006Gb-LT; Thu, 14 Jul 2005 23:33:29 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id j6F3OuCK007498; Thu, 14 Jul 2005 22:24:56 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id j6F3OmC12530; Thu, 14 Jul 2005 22:24:48 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: <200507142205.j6EM51f12059@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 14 Jul 2005 17:05:01 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40901 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40901 >>From my previous message: There is the question of whether my changes should be reverted. They do not result in any change in behavior whatsoever, but they avoid confusion for somebody who expands the macro to see what the define-minor-mode form he wrote really does (as anybody who uses define-minor-mode should do). So it seems that my changes actually were positive, even though not really necessary. It is a little bit inconsistent to do this for :initialize and not for :set and :type, but since :initialize will be used more often, it might make sense. More precisely, without my changes, if you specify an explicit :initialize keyword, the expansion of the define-minor-mode form contains two :initialize keywords, first ":initialize 'custom-initialize-default" and then, at some later place the explicit :initialize. The last one, the explicit :initialize wins, but since the two may be separated by other code, it might confuse the person reading the expanded version of the macro. With my changes (that is with current CVS), the defcustom has only one :initialize form, the explicitly specified one. However, explicitly specified :set or :type keywords still expand to defcustoms with two :set or :type keywords. Sincerely, Luc.