From: Luc Teirlinck <teirllm@dms.auburn.edu>
Subject: timers and match-data
Date: Mon, 30 May 2005 20:40:42 -0500 (CDT) [thread overview]
Message-ID: <200505310140.j4V1egr16148@raven.dms.auburn.edu> (raw)
(elisp)Saving Match Data contains:
Emacs automatically saves and restores the match data when it runs
process filter functions (*note Filter Functions::) and process
sentinels (*note Sentinels::).
But this apparently does not apply to timers.
This leads to very concrete problems. If one autoreverts the Buffer
Menu, if Buffer-menu-use-header-line is t, enable-local-variables is
'ask and one does `C-h n' and waits too long before answering `y' to
the y-or-n-p question,, the NEWS does not get put in Outline Mode,
because of a Local Variables error, due to the fact that autoreverting
the Buffer Menu changed the match data.
To avoid such problems, either:
1. Every function that waits for input or otherwise allows for timers
to run should save and restore the match data.
2. We should make timers automatically save and restore match data.
3. Any individual timer function that potentially could alter the
match data should save and restore the match data.
Which one?
If (3), I could make autorevert use save-match-data. If (1), the
patch below to files.el solves the `C-h n' problem.
===File ~/files-diff========================================
*** files.el 20 May 2005 21:47:22 -0500 1.772
--- files.el 30 May 2005 19:26:40 -0500
***************
*** 2172,2181 ****
(save-excursion
(beginning-of-line)
(set-window-start (selected-window) (point)))
! (y-or-n-p (format string
! (if buffer-file-name
! (file-name-nondirectory buffer-file-name)
! (concat "buffer " (buffer-name)))))))))
(defun hack-local-variables-prop-line (&optional mode-only)
"Set local variables specified in the -*- line.
--- 2172,2182 ----
(save-excursion
(beginning-of-line)
(set-window-start (selected-window) (point)))
! (save-match-data
! (y-or-n-p (format string
! (if buffer-file-name
! (file-name-nondirectory buffer-file-name)
! (concat "buffer " (buffer-name))))))))))
(defun hack-local-variables-prop-line (&optional mode-only)
"Set local variables specified in the -*- line.
============================================================
next reply other threads:[~2005-05-31 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 1:40 Luc Teirlinck [this message]
2005-05-31 3:18 ` timers and match-data Luc Teirlinck
2005-05-31 17:47 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505310140.j4V1egr16148@raven.dms.auburn.edu \
--to=teirllm@dms.auburn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).