From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: org-mode and mode hooks. Date: Sun, 29 May 2005 21:50:05 -0500 (CDT) Message-ID: <200505300250.j4U2o5013572@raven.dms.auburn.edu> References: <87y8a3mnz8.fsf@xs4all.nl> <87ll63weye.fsf-monnier+emacs@gnu.org> <200505252135.j4PLZvt26969@raven.dms.auburn.edu> <87hdgrufcl.fsf-monnier+emacs@gnu.org> <200505260359.j4Q3xbj28809@raven.dms.auburn.edu> <87is16rsid.fsf-monnier+emacs@gnu.org> <200505261501.j4QF17h00246@raven.dms.auburn.edu> <87psveq60w.fsf-monnier+emacs@gnu.org> <200505271717.j4RHHGD07067@raven.dms.auburn.edu> <200505290157.j4T1vus10117@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1117421362 32036 80.91.229.2 (30 May 2005 02:49:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 30 May 2005 02:49:22 +0000 (UTC) Cc: Lute.Kamstra.lists@xs4all.nl, dominik@science.uva.nl, mmaug@yahoo.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 30 04:49:15 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DcaKe-0003uY-Dj for ged-emacs-devel@m.gmane.org; Mon, 30 May 2005 04:48:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DcaPR-0004u6-M6 for ged-emacs-devel@m.gmane.org; Sun, 29 May 2005 22:53:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DcaP2-0004rh-15 for emacs-devel@gnu.org; Sun, 29 May 2005 22:53:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DcaP0-0004qY-Ey for emacs-devel@gnu.org; Sun, 29 May 2005 22:53:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DcaP0-0004qD-1I for emacs-devel@gnu.org; Sun, 29 May 2005 22:53:18 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DcaNp-0005PG-DA; Sun, 29 May 2005 22:52:05 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id j4U2oZCK023310; Sun, 29 May 2005 21:50:35 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id j4U2o5013572; Sun, 29 May 2005 21:50:05 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Sun, 29 May 2005 08:04:39 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37878 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37878 >>From my previous message: Note that even after this patch, there is one potentially troublesome case left... Sorry, I was confused. That entire long paragraph makes no sense (sorry about that). Without MODE-stored-mode, I can not avoid some inefficiency for non-file buffers (unnecessarily dis- and re-enable the mode once), unless I somehow can recognize whether we are running from a timer or process. (I can not immediately think of way to do that. Is there away?) Getting rid of the one remaining bug I described _and_ avoiding a similar inefficiency for file buffers can be accomplished using the following alternate ,buffers function, so it seems definitely better than the one in my previous patch: ;; The function that calls TURN-ON in each buffer. (defun ,buffers () (dolist (buf ,buffers) (and (buffer-live-p buf) (not buffer-file-name) (with-current-buffer buf (when mode (,mode -1)) (,turn-on))))) It is actually _here_ (in after-change-major-mode-hook) that disabling and re-enabling is unlikely to occur, so getting rid of the remaining bug carries no real price, but getting rid of MODE-stored-hook does carry some price, for non-file buffers. I will still think of this further. Sincerely, Luc.