From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: lispref/frames.texi and xmenu.c Date: Sun, 1 May 2005 15:55:14 -0500 (CDT) Message-ID: <200505012055.j41KtEN24440@raven.dms.auburn.edu> References: <200505011335.j41DZK123269@raven.dms.auburn.edu> <01c54e80$Blat.v2.4$606c0700@zahav.net.il> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1114981512 12064 80.91.229.2 (1 May 2005 21:05:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 1 May 2005 21:05:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 01 23:05:11 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DSLcD-0004tu-QK for ged-emacs-devel@m.gmane.org; Sun, 01 May 2005 23:04:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSLiz-0007MC-FY for ged-emacs-devel@m.gmane.org; Sun, 01 May 2005 17:11:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DSLad-0003m6-Mq for emacs-devel@gnu.org; Sun, 01 May 2005 17:03:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DSLaP-0003cF-9m for emacs-devel@gnu.org; Sun, 01 May 2005 17:02:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSLaN-0003Vj-I2 for emacs-devel@gnu.org; Sun, 01 May 2005 17:02:43 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DSLXT-0006Xh-FK; Sun, 01 May 2005 16:59:43 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id j41KtLog024837; Sun, 1 May 2005 15:55:22 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id j41KtEN24440; Sun, 1 May 2005 15:55:14 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: eliz@gnu.org In-reply-to: <01c54e80$Blat.v2.4$606c0700@zahav.net.il> (eliz@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36564 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36564 Eli Zaretskii wrote: > I can not check, but does quitting or popping down that popup-menu > when `x-popup-dialog' is used in this situation quit or return nil? Please post a test case, a Lisp code that can be eval'ed and instructions to follow, and I will tell you what happens. (There's one thing one should remember when dealing with xmenu issues: on some configurations, I think precisely those which the manual has in mind, there's no such thing as ``popping down the menu''; one needs to click something for the menu to disappear.) The situation has completely changed (on GNU/Linux) since Richard installed a patch. But there still might be problems on other operating systems. Richard Stallman wrote: Studying the code, I see that the original x-popup-menu in the non-Xt case does quit if the user cancels, except in the case where it was invoked for a mouse click. (This is determined by the POSITION argument.) When the code was adapted to Xt, that part of the functionality was lost, it looks like. Seeing this, I concluded that the right thing to do is to make all the implementations of x-popup-menu quit also, under the same condition. I implemented this in xmenu.c, but not in w32menu.c and macmenu.c. The things to test are (after updating your CVS to include Richard's changes): M-: (x-popup-menu t '("TITLE" ("PANE" . ("LINE1" . 1)))) and then making the menu disappear by clicking away from the menu (I referred abusively to this as "popping down") should quit instead of returning nil. On GNU/Linux this returned nil before Richard's change, but it quits now. The same for: M-: (x-popup-dialog t '("PANE" . ("LINE1" . 1))) and then making the dialog disappear using the window mananger (or by clicking away from the dialog, assuming this actually makes the dialog disappear. (Should also quit, not return nil). On GNU/Linux, this already quit before Richard's recent change, but it returned nil in 21.3. Sincerely, Luc.