Re: [david.reitter@gmail.com: recentf: "Select coding system" on quit]

[Kenichi Handa <handa@m17n.org>]

In article <E1DNFJN-0005VA-0Z@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

> Would you please DTRT and ack?

> ------- Start of forwarded message -------
> To: emacs-pretest-bug@gnu.org
> From: David Reitter <david.reitter@gmail.com>
> Date: Sun, 17 Apr 2005 10:29:34 +0100
> Subject: recentf: "Select coding system" on quit
[...]
> The recentf library asks the user "Select coding system" upon quitting 
> emacs what coding system to use when one of the recent files is one 
> with non-ascii characters, instead of non-interactively (i.e. 
> automatically) choosing a safe coding system such as utf-8.

> This is generated by mule-cmds.el, possibly 
> select-safe-coding-system-interactively or something like that.

I think the attached patch will fix the problem.  Shall I
install it?

The code:

   (if (coding-system-p 'utf-8-emacs) ...)

is for emacs-unicode.

---
Ken'ichi HANDA
handa@m17n.org


2005-04-21  Kenichi Handa  <handa@m17n.org>

	* recentf.el (recentf-save-file-coding-system): New variable.
	(recentf-save-list): Encode the file by
	recentf-save-file-coding-system and add coding: tag.

	* international/mule-cmds.el: Add autoload for widget-value in
	eval-when-compile

*** recentf.el	25 Mar 2005 10:37:27 +0900	1.35
--- recentf.el	21 Apr 2005 14:23:21 +0900	
***************
*** 1137,1142 ****
--- 1137,1148 ----
    ";;; Automatically generated by `recentf' on %s.\n"
    "Header to be written into the `recentf-save-file'.")
  
+ (defconst recentf-save-file-coding-system
+   (if (coding-system-p 'utf-8-emacs)
+       'utf-8-emacs
+     'emacs-mule)
+   "Coding system of the file `recentf-save-file'.")
+ 
  (defun recentf-save-list ()
    "Save the recent list.
  Write data into the file specified by `recentf-save-file'."
***************
*** 1144,1152 ****
--- 1150,1162 ----
    (condition-case error
        (with-temp-buffer
  	(erase-buffer)
+ 	(set-buffer-file-coding-system recentf-save-file-coding-system)
  	(insert (format recentf-save-file-header (current-time-string)))
  	(recentf-dump-variable 'recentf-list recentf-max-saved-items)
  	(recentf-dump-variable 'recentf-filter-changer-state)
+ 	(insert ";;; Local Variables:\n"
+ 		(format ";;; coding: %s\n" recentf-save-file-coding-system)
+ 		";;; End:\n")
  	(write-file (expand-file-name recentf-save-file))
  	nil)
      (error