From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: inf-lisp.el Date: Tue, 19 Apr 2005 22:55:34 -0500 (CDT) Message-ID: <200504200355.j3K3tYR13542@raven.dms.auburn.edu> References: <200504200035.j3K0ZTc12822@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1113969802 32213 80.91.229.2 (20 Apr 2005 04:03:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 20 Apr 2005 04:03:22 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 20 06:03:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DO6Qh-0005fY-2I for ged-emacs-devel@m.gmane.org; Wed, 20 Apr 2005 06:03:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DO6V8-0005T8-42 for ged-emacs-devel@m.gmane.org; Wed, 20 Apr 2005 00:07:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DO6Ux-0005SV-Ib for emacs-devel@gnu.org; Wed, 20 Apr 2005 00:07:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DO6Uw-0005Rp-EX for emacs-devel@gnu.org; Wed, 20 Apr 2005 00:07:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DO6Uw-0004tn-CE for emacs-devel@gnu.org; Wed, 20 Apr 2005 00:07:34 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DO6N8-00035Q-TE for emacs-devel@gnu.org; Tue, 19 Apr 2005 23:59:31 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id j3K3vS9N028643; Tue, 19 Apr 2005 22:57:28 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id j3K3tYR13542; Tue, 19 Apr 2005 22:55:34 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: teirllm@dms.auburn.edu In-reply-to: <200504200035.j3K0ZTc12822@raven.dms.auburn.edu> (message from Luc Teirlinck on Tue, 19 Apr 2005 19:35:29 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36143 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36143 >>From my previous patch: *************** *** 110,117 **** ;;; "This function binds many inferior-lisp commands to C-c bindings, ;;;where they are more accessible. C-c bindings are reserved for the ;;;user, so these bindings are non-standard. If you want them, you should ! ;;;have this function called by the inferior-lisp-load-hook: ! ;;; (setq inferior-lisp-load-hook '(inferior-lisp-install-letter-bindings)) ;;;You can modify this function to install just the bindings you want." (defun inferior-lisp-install-letter-bindings () (define-key lisp-mode-map "\C-ce" 'lisp-eval-defun-and-go) --- 118,125 ---- ;;; "This function binds many inferior-lisp commands to C-c bindings, ;;;where they are more accessible. C-c bindings are reserved for the ;;;user, so these bindings are non-standard. If you want them, you should ! ;;;have this function called by the inferior-lisp-mode-hook: ! ;;; (add-hook 'inferior-lisp-mode-hook 'inferior-lisp-install-letter-bindings) ;;;You can modify this function to install just the bindings you want." (defun inferior-lisp-install-letter-bindings () (define-key lisp-mode-map "\C-ce" 'lisp-eval-defun-and-go) *************** I changed my mind on this part. Certainly, add-hook is better than setq. But adding this to inferior-lisp-load-hook, as in the original version, is _relatively_ better than adding it to inferior-lisp-mode-hook. Neither of the two really seem to make a lot of sense, however, and the comment is preceded by: ;;; This function exists for backwards compatibility. ;;; Previous versions of this package bound commands to C-c ;;; bindings, which is not allowed by the gnumacs standard. So this particular part of the patch does not seem to matter too much. Sincerely, Luc.