From: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: face colors on 256 colors terminals
Date: Wed, 06 Apr 2005 22:14:08 -0700 [thread overview]
Message-ID: <200504070514.j375EBAH009933@scanner2.ics.uci.edu> (raw)
In-Reply-To: <x58y3va119.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 07 Apr 2005 02:22:26 +0200")
David Kastrup <dak@gnu.org> writes:
> Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> > "Eli Zaretskii" <eliz@gnu.org> writes:
> >
> > > > Cc: emacs-devel@gnu.org
> > > > From: Dan Nicolaescu <dann@ics.uci.edu>
> > > > Date: Wed, 06 Apr 2005 10:52:26 -0700
> > > >
> > > > Agreed. The problem seems to be that tty-colors.el and color-name-rgb-alist
> > > > don't use the same of scaling.
> > > > Do you want me to do check if rescaling the values in
> > > > color-name-rgb-alist gives good results?
> > >
> > > Yes, please.
> >
> > I checked and I could not see any difference in behavior compared to the
> > approach in my first patch.
> >
> > Is this OK?
>
> I am certain I am missing the context, but is this really related to
> the #RRGGBB notation in any manner? It really looks awful to me if
> white gets defined as #ff00ff00ff00, so I'd like to be as bothersome
> as to be grateful for some factual reassurance that we are indeed
> catering here for a real instead of a perceived problem, and that the
> fix in that manner is the right thing to do.
Well, there patch has 3 parts.
Part1:
The patch to xterm-register-default-colors changes the way the 8bit
R/G/B values are computed for a 256 color xterm to match what the
xterm currently does. This part should be correct and
non-controversial.
Part2:
xterm-rgb-convert-to-16bit converts an 8bit color value (say Y) to a 16bit
color. As we discussed, the result can either be Y0 or YY.
My empirical testing show that there's no visible difference between
the two.
I have no opinion which is better, if any.
Eli seems to think that Y0 is the correct conversion, I don't have a
problem going with that. (although "esthetically" YY looks better).
Part3:
color-name-rgb-alist contains the colors in rgb.txt converted to
16bit. It should use the same conversion as
xterm-rgb-convert-to-16bit. So this part is only needed if the
conversion performed by xterm-rgb-convert-to-16bit is Y->Y0.
(Hmmm, if the Y->Y0 conversion is used then
pc-win.el:msdos-color-values needs to be changed in the same way).
So when a final decision is made about using the YY or Y0 conversion I
can check in the corresponding patch.
next prev parent reply other threads:[~2005-04-07 5:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-06 8:17 face colors on 256 colors terminals Dan Nicolaescu
2005-04-06 17:23 ` Eli Zaretskii
2005-04-06 17:36 ` David Kastrup
2005-04-06 17:46 ` Eli Zaretskii
2005-04-06 18:03 ` David Kastrup
2005-04-06 18:26 ` Dan Nicolaescu
2005-04-07 20:43 ` James Cloos
2005-04-08 1:17 ` Dan Nicolaescu
2005-04-08 10:52 ` Eli Zaretskii
2005-04-08 15:13 ` Dan Nicolaescu
2005-04-09 8:06 ` Eli Zaretskii
2005-04-06 17:52 ` Dan Nicolaescu
[not found] ` <01c53aea$Blat.v2.4$16ee4740@zahav.net.il>
2005-04-06 23:50 ` Dan Nicolaescu
2005-04-07 0:22 ` David Kastrup
2005-04-07 3:58 ` Eli Zaretskii
2005-04-07 5:14 ` Dan Nicolaescu [this message]
2005-04-07 10:23 ` David Kastrup
2005-04-08 1:13 ` Dan Nicolaescu
2005-04-07 3:55 ` Eli Zaretskii
[not found] ` <200504062134.j36LY8AH022227@scanner2.ics.uci.edu>
2005-04-07 3:53 ` Eli Zaretskii
2005-04-07 18:27 ` Dan Nicolaescu
2005-04-08 10:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504070514.j375EBAH009933@scanner2.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).