From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: `xterm-mouse-mode' has a bogus Custom group Date: Fri, 1 Apr 2005 21:51:51 -0600 (CST) Message-ID: <200504020351.j323ppS16391@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1112414612 21007 80.91.229.2 (2 Apr 2005 04:03:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2005 04:03:32 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 02 06:03:30 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DHZr6-0003Y4-SA for ged-emacs-devel@m.gmane.org; Sat, 02 Apr 2005 06:03:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DHZsV-0006Mp-G2 for ged-emacs-devel@m.gmane.org; Fri, 01 Apr 2005 23:04:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DHZsF-0006Lj-Gb for emacs-devel@gnu.org; Fri, 01 Apr 2005 23:04:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DHZsE-0006L6-F9 for emacs-devel@gnu.org; Fri, 01 Apr 2005 23:04:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DHZsD-0006KD-MI for emacs-devel@gnu.org; Fri, 01 Apr 2005 23:04:37 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DHZh0-0007ZQ-Ml for emacs-devel@gnu.org; Fri, 01 Apr 2005 22:53:02 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id j323qw9N000069 for ; Fri, 1 Apr 2005 21:52:58 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id j323ppS16391; Fri, 1 Apr 2005 21:51:51 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35488 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35488 `xterm-mouse-mode' relies on a bogus default :group, chosen by define-minor-mode, xterm-mouse, that does not have one of the major groups as an ancestor (in fact, that does not even have a parent group). As a result, users can never find it while browsing Custom using `customize-browse' or similar. This is bad, since it is an option many people who have to often run Emacs in an xterm might want to set. I believe that we have to choose a valid group for `xterm-mouse-mode'. Maybe the most logical is 'mouse, as the patch below implements. Another frustration I had with `xterm-mouse-mode' was finding appropriate documentation starting from the Custom buffer. In the Custom buffer, you get the documentation for the variable, which simply says to read the docstring of the function instead: See the command `xterm-mouse-mode' for a description of this minor-mode. If you click on that link, you do not get the doc for the function yet, but a buffer telling you once more that `xterm-mouse-mode' is both a variable and a command and also has a plist. You have to click on `Command:". Then we finally get the function docstring, which barely says anything of substance either. Everything but the last fact applies to just about any minor mode defined by define-minor-mode. The only thing the patch below does something about is the last fact: it expands the command docstring. (Most of the new text is based on the Emacs manual documentation.) I can install the patch below if desired. ===File ~/xt-mouse-diff===================================== *** xt-mouse.el 17 Jan 2005 10:30:26 -0600 1.24 --- xt-mouse.el 01 Apr 2005 20:55:39 -0600 *************** *** 155,162 **** "Toggle XTerm mouse mode. With prefix arg, turn XTerm mouse mode on iff arg is positive. ! Turn it on to use emacs mouse commands, and off to use xterm mouse commands." ! nil " Mouse" nil :global t (if xterm-mouse-mode ;; Turn it on (unless window-system --- 155,167 ---- "Toggle XTerm mouse mode. With prefix arg, turn XTerm mouse mode on iff arg is positive. ! Turn it on to use emacs mouse commands, and off to use xterm mouse commands. ! This works in terminal emulators compatible with xterm. Only single clicks ! are supported. When turned on, the normal xterm mouse functionality is still ! available by holding down the SHIFT key while pressing the mouse button. ! The Linux console supports this mode if it has support for the mouse enabled, ! for instance using the gpm daemon." ! nil " Mouse" nil :global t :group 'mouse (if xterm-mouse-mode ;; Turn it on (unless window-system ============================================================