* read-file-name-internal changed
@ 2005-03-30 19:56 Tak Ota
2005-03-30 22:24 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Tak Ota @ 2005-03-30 19:56 UTC (permalink / raw)
Some recent change, I suspect Stefan's change on 2005-03-28, modified
the behavior of read-file-name-internal which is called from ffap.el.
It used to return
"//server/"
for
(read-file-name-internal "//server/" "c:/emacs/" nil)
but now it returns
"/server/"
This hinders to input network path on w32 platform.
-Tak
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: read-file-name-internal changed
2005-03-30 19:56 read-file-name-internal changed Tak Ota
@ 2005-03-30 22:24 ` Stefan Monnier
2005-03-30 22:33 ` Stefan Monnier
2005-03-30 23:09 ` Tak Ota
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2005-03-30 22:24 UTC (permalink / raw)
Cc: emacs-devel
> Some recent change, I suspect Stefan's change on 2005-03-28, modified
> the behavior of read-file-name-internal which is called from ffap.el.
> It used to return
> "//server/"
> for
> (read-file-name-internal "//server/" "c:/emacs/" nil)
Hmm.... What does (substitute-in-file-name "//server/") return?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: read-file-name-internal changed
2005-03-30 22:24 ` Stefan Monnier
@ 2005-03-30 22:33 ` Stefan Monnier
2005-03-30 23:24 ` Tak Ota
2005-03-30 23:09 ` Tak Ota
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2005-03-30 22:33 UTC (permalink / raw)
Cc: emacs-devel
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Some recent change, I suspect Stefan's change on 2005-03-28, modified
>> the behavior of read-file-name-internal which is called from ffap.el.
>> It used to return
>> "//server/"
>> for
>> (read-file-name-internal "//server/" "c:/emacs/" nil)
> Hmm.... What does (substitute-in-file-name "//server/") return?
I see I got it, I've just installed the patch below which should fix
your problem. Please confirm,
Than you,
Stefan
Index: fileio.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fileio.c,v
retrieving revision 1.534
diff -u -u -b -r1.534 fileio.c
--- fileio.c 28 Mar 2005 21:31:14 -0000 1.534
+++ fileio.c 30 Mar 2005 22:29:14 -0000
@@ -2078,7 +2078,7 @@
#if defined (APOLLO) || defined (WINDOWSNT) || defined(CYGWIN)
/* // at start of file name is meaningful in Apollo,
WindowsNT and Cygwin systems. */
- && !(IS_DIRECTORY_SEP (p[0]) && p - 1 != nm)
+ && !(IS_DIRECTORY_SEP (p[0]) && p - 1 == nm)
#endif /* not (APOLLO || WINDOWSNT || CYGWIN) */
)
{
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: read-file-name-internal changed
2005-03-30 22:33 ` Stefan Monnier
@ 2005-03-30 23:24 ` Tak Ota
0 siblings, 0 replies; 5+ messages in thread
From: Tak Ota @ 2005-03-30 23:24 UTC (permalink / raw)
Cc: emacs-devel
I confirm that the problem is now fixed. Thank you.
-Tak
Wed, 30 Mar 2005 14:33:45 -0800: "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
> >>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
> >> Some recent change, I suspect Stefan's change on 2005-03-28, modified
> >> the behavior of read-file-name-internal which is called from ffap.el.
> >> It used to return
>
> >> "//server/"
> >> for
> >> (read-file-name-internal "//server/" "c:/emacs/" nil)
>
> > Hmm.... What does (substitute-in-file-name "//server/") return?
>
> I see I got it, I've just installed the patch below which should fix
> your problem. Please confirm,
> Than you,
>
>
> Stefan
>
>
> Index: fileio.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/fileio.c,v
> retrieving revision 1.534
> diff -u -u -b -r1.534 fileio.c
> --- fileio.c 28 Mar 2005 21:31:14 -0000 1.534
> +++ fileio.c 30 Mar 2005 22:29:14 -0000
> @@ -2078,7 +2078,7 @@
> #if defined (APOLLO) || defined (WINDOWSNT) || defined(CYGWIN)
> /* // at start of file name is meaningful in Apollo,
> WindowsNT and Cygwin systems. */
> - && !(IS_DIRECTORY_SEP (p[0]) && p - 1 != nm)
> + && !(IS_DIRECTORY_SEP (p[0]) && p - 1 == nm)
> #endif /* not (APOLLO || WINDOWSNT || CYGWIN) */
> )
> {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: read-file-name-internal changed
2005-03-30 22:24 ` Stefan Monnier
2005-03-30 22:33 ` Stefan Monnier
@ 2005-03-30 23:09 ` Tak Ota
1 sibling, 0 replies; 5+ messages in thread
From: Tak Ota @ 2005-03-30 23:09 UTC (permalink / raw)
Cc: emacs-devel
Wed, 30 Mar 2005 14:24:50 -0800: "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
> > Some recent change, I suspect Stefan's change on 2005-03-28, modified
> > the behavior of read-file-name-internal which is called from ffap.el.
> > It used to return
>
> > "//server/"
> > for
> > (read-file-name-internal "//server/" "c:/emacs/" nil)
>
> Hmm.... What does (substitute-in-file-name "//server/") return?
>
>
> Stefan
That seems to be the culprit.
(substitute-in-file-name "//server/") returns
"/server/"
on 2005-03-29 built emacs while the same function returns
"//server/"
on 2005-03-21 built emacs.
-Tak
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-03-30 23:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-30 19:56 read-file-name-internal changed Tak Ota
2005-03-30 22:24 ` Stefan Monnier
2005-03-30 22:33 ` Stefan Monnier
2005-03-30 23:24 ` Tak Ota
2005-03-30 23:09 ` Tak Ota
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).