From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Coding system conversion error Date: Mon, 14 Feb 2005 15:15:24 +0900 (JST) Message-ID: <200502140615.PAA00347@etlken.m17n.org> References: <20050205170221.ZTBD24781.mxfep02.bredband.com@coolsville.localdomain> <738f9db09f1986269b8f5719d45d2dd5@swipnet.se> <4207DAF0.6000204@swipnet.se> <4209342E.5010701@swipnet.se> <165be0ad579be34852d18cc600114175@swipnet.se> <420BD292.6040607@swipnet.se> <200502120157.KAA24490@etlken.m17n.org> <30e47fd1ee5ebcc03c15fe8c905bc525@swipnet.se> <200502130014.JAA26774@etlken.m17n.org> <87y8ds4f6d.fsf-monnier+emacs@gnu.org> <200502140102.KAA29430@etlken.m17n.org> <50e2f24c825ce097d2da5c2208fd5a91@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1108363427 15880 80.91.229.2 (14 Feb 2005 06:43:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 Feb 2005 06:43:47 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 14 07:43:46 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D0ZxH-0007pd-9i for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2005 07:43:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D0aCl-0003m7-D4 for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2005 01:59:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D0aA4-0001v5-CV for emacs-devel@gnu.org; Mon, 14 Feb 2005 01:56:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D0a9u-0001rR-TJ for emacs-devel@gnu.org; Mon, 14 Feb 2005 01:56:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D0a9s-0001ny-Gy for emacs-devel@gnu.org; Mon, 14 Feb 2005 01:56:36 -0500 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1D0ZW3-0002JW-GX for emacs-devel@gnu.org; Mon, 14 Feb 2005 01:15:28 -0500 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j1E6FPXD005000; Mon, 14 Feb 2005 15:15:25 +0900 Original-Received: from etlken.m17n.org (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.12.3/8.12.3/Debian-7.1) with ESMTP id j1E6FPPN004729; Mon, 14 Feb 2005 15:15:25 +0900 Original-Received: (from handa@localhost) by etlken.m17n.org (8.8.8+Sun/3.7W-2001040620) id PAA00347; Mon, 14 Feb 2005 15:15:24 +0900 (JST) Original-To: "Jan D." In-reply-to: <50e2f24c825ce097d2da5c2208fd5a91@swipnet.se> (jan.h.d@swipnet.se) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/21.3.50 (sparc-sun-solaris2.6) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:33369 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:33369 In article <50e2f24c825ce097d2da5c2208fd5a91@swipnet.se>, "Jan D." writes: >> * xselect.c (lisp_data_to_selection_data): If OBJ is a non-ASCII >> multibyte string, signal an error instead of aborting. > The error message can be improved if you put it in > x_handle_selection_request instead (lisp_data_to_selection_data is only > called from there). Then you can get the target_symbol in to the error > text, which otherwise can be hard to know. That's true. But I think the error should be signaled just before we use the data. Otherwise, the other code will slip into between the call of Fsignal and the place where the data is used. --- Ken'ichi HANDA handa@m17n.org